Fix LombokValToFinalVar in loops

[MBoegers]

What's changed?

LombokValToFinalVar now avoids useing JavaTemplate in for each loops were type attribution is not secure enough and parsing might fail.

What's your motivation?

fix handling in for each loops

Anything in particular you'd like reviewers to focus on?

We assumed that for(var s : strings) is better migrated to for(val s : strings)than for(final var s : strings) as it more comply with the common usage.

Anyone you would like to review specifically?

Have you considered any alternatives or workarounds?

Fixing parser issue in template logic connected to val in loops, see

• lombok.val Support rewrite#5637

Any additional context

Checklist

• I've added unit tests to cover both positive and negative cases
• I've read and applied the recipe conventions and best practices
• I've used the IntelliJ IDEA auto-formatter on affected files

[github-actions]

Some suggestions could not be made:

• src/test/java/org/openrewrite/java/migrate/lombok/LombokValToFinalVarTest.java
  • lines 20-21

[github-actions]

Some suggestions could not be made:

• src/test/java/org/openrewrite/java/migrate/lombok/LombokValToFinalVarTest.java
  • lines 21-21

[timtebeek]

This (now) isolated change can already be merged I think, but in chat we said to leave the final review to @jkschneider (no rush).

[timtebeek]

This is now fully disconnected from the potential underlying issue we could separately explore in

• lombok.val Support rewrite#5637

As it stands we're not changing the shape of things in this recipe now; merely fixing an issue that was seen at a customer site.