Fix Lombok recipes incorrectly replacing getters/setters accessing other objects' fields

[timtebeek]

Summary

• Fixes Lombok recipes should not remove getter/setter methods when the method body is referring to another classes' field #872

This PR fixes an issue where UseLombokGetter and UseLombokSetter recipes were incorrectly replacing getter/setter methods that access fields of other objects.

Problem

The recipes were treating expressions like sample.number as if they were accessing a field of the current class, when in reality they were accessing a field of another object (sample).

Before (incorrect behavior):

private class Inner {
    static Sample sample = null;
    
    private Long getNumber() {
        return sample.number;  // Accessing another object's field
    }
}

Would incorrectly transform to:

@Getter(AccessLevel.PRIVATE)
public Long number;  // Added to wrong class!

Solution

Modified LombokUtils.isGetter() and LombokUtils.isSetter() to only handle this.field patterns for J.FieldAccess expressions. Now the recipes correctly identify that methods accessing fields of other objects should not be replaced with Lombok annotations.

Changes

• Fixed LombokUtils.isGetter() to check that field access targets are explicitly this
• Fixed LombokUtils.isSetter() with the same pattern for consistency
• Added test cases for both getter and setter scenarios

Test Plan

• Added test case noChangeWhenMethodReturnsFieldOfAnotherObject() in UseLombokGetterTest
• Added test case noChangeWhenMethodSetsFieldOfAnotherObject() in UseLombokSetterTest
• All existing Lombok tests pass

🤖 Generated with Claude Code