Add support for HttpStatus in SimplifyWebTestClientCalls#664
Merged
timtebeek merged 3 commits intoopenrewrite:mainfrom Jan 12, 2025
Merged
Conversation
timtebeek
approved these changes
Jan 12, 2025
Member
timtebeek
left a comment
There was a problem hiding this comment.
Thanks a lot @barbulescu ! I've only applied some light polish to minimize the diff and look more like other recipes. Great to have these cases converted as well.
Contributor
Author
|
np, OpenRewrite is a great tool and I am glad to help as much as I can |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SimplifyWebTestClientCallssupports only int parameters forisEqualTomethod.What's changed?
This PR adds support for:
isEqualTo(HttpStatus.valueOf(200))isEqualTo(HttpStatusCode.valueOf(200))isEqualTo(HttpStatus.OK)What's your motivation?
Fix disabled test in
SimplifyWebTestClientCallsTestand to be feature complete on this recipe.Anything in particular you'd like reviewers to focus on?
Probably implementation can be improved but I am not yet familiar with OpenRewrite patterns.
Anyone you would like to review specifically?
Have you considered any alternatives or workarounds?
none
Any additional context
Checklist