Pass literal values to fix ReplaceStringLiteralWithConstant validation#947
Merged
Pass literal values to fix ReplaceStringLiteralWithConstant validation#947
Conversation
…tion ReplaceStringLiteralsWithMediaTypeConstants and ReplaceStringLiteralsWithHttpHeadersConstants were passing null for literalValue, causing ReplaceStringLiteralWithConstant.validate() to attempt reflective class loading of org.springframework.http.MediaType and org.springframework.http.HttpHeaders. Since spring-web is not a dependency of rewrite-spring, Class.forName() always fails with ClassNotFoundException, producing validation errors like: fullyQualifiedConstantName was 'org.springframework.http.MediaType.TEXT_HTML_VALUE' but it No class for specified name was found. Fix by providing the actual string literal values directly, so validation no longer needs reflection. Also adds the missing APPLICATION_YAML_VALUE constant.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's Changed
ReplaceStringLiteralsWithMediaTypeConstantsandReplaceStringLiteralsWithHttpHeadersConstantswere passingnullforliteralValuewhen constructingReplaceStringLiteralWithConstantinstances. This causedvalidate()to attempt reflective class loading viaClass.forName("org.springframework.http.MediaType")/Class.forName("org.springframework.http.HttpHeaders"). Sincespring-webis not a dependency ofrewrite-spring, this always fails withClassNotFoundException, producing validation errors like:This affected all constants in both recipes, not just the
MediaTypeones.Fix
Provide the actual string literal values directly (e.g.,
"text/html"forTEXT_HTML_VALUE,"Accept"forACCEPT), so validation succeeds without needing reflection. Values were verified against Spring Framework 6.2.Also adds the missing
APPLICATION_YAML_VALUE("application/yaml") constant that exists in Spring Framework 6.x.Test plan
ReplaceLiteralsTesttests passorg.openrewrite.java.spring.http.*tests pass