Add Gradle integration tests for Boot 4 migration version pinning#948
Closed
Add Gradle integration tests for Boot 4 migration version pinning#948
Conversation
Regression tests for moderneinc/customer-requests#1920 to verify that the Spring Boot 4 migration recipe: - Does not pin BOM-managed starters that have no explicit version - Does not pin renamed starters (e.g. web -> webmvc) with hardcoded versions - Updates springBootVersion property in gradle.properties - Preserves GString variable references in dependency declarations
Add gradle.properties with springBootVersion to the remaining two tests that were using inline literal plugin versions. All four tests now consistently verify that the springBootVersion property is updated to 4.0.x and that starters are not pinned.
Contributor
|
Think we can close this one and only keep |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UpgradeSpringBoot_4_0GradleTestwith 4 integration tests verifying the Spring Boot 4 migration recipe handles Gradle dependency versions correctlyContext
Regression tests for https://github.com/moderneinc/customer-requests/issues/1920 where customers reported that BOM-managed Spring Boot starters were getting individually pinned to
4.0.3during migration.The root cause fix is in Preserve GString/StringTemplate in ChangeDependency when version unchanged rewrite#6830 (
ChangeDependencyGString/StringTemplate path). These tests verify the end-to-end behavior through the full recipe chain.Tests
doNotPinBomManagedStarters- literal plugin version + BOM-managed starters without versiondoNotPinRenamedStarters- renamed starters (web -> webmvc) preserve no-version declarationupdateSpringBootVersionProperty-${springBootVersion}in plugins block + gradle.properties updateddoNotPinStartersWithGStringVersion- GString version variable preserved, not collapsed to literal