Pass resolvers to JS/Python RPC so PrepareRecipe callbacks can resolve Maven recipes (#6742)

* Fall back to RecipeLoader when ecosystem resolver is missing

When the PrepareRecipe handler finds a recipe in the marketplace but
listing.prepare() throws because no resolver matches the bundle's
ecosystem (e.g., a "maven"-bundled recipe when only a "runtime" resolver
is available), the handler now catches the exception and falls through
to RecipeLoader. This allows recipes that are already on the classpath
to be loaded by class name instead of failing outright.

This fixes recipe runs on Node.js repositories where JS recipes use
preconditions like usesType() or usesMethod() that call back to the
Java side to prepare Java recipes. Without a Maven resolver wired into
the RPC endpoint, these callbacks previously failed with
"No available resolver for 'maven' ecosystem".

* Accept resolvers in JavaScriptRewriteRpc and PythonRewriteRpc

Both RPC classes were calling the 2-arg RewriteRpc constructor which
passes emptyList() for resolvers. When a JS/Python recipe's
preconditions reference Java recipes bundled under the "maven"
ecosystem, the PrepareRecipe callback fails with "No available resolver
for 'maven' ecosystem".

Add a resolvers field to both Builders (defaulting to emptyList() for
backward compatibility) and pass them through to the 3-arg super
constructor.

* Polish

* Remove no longer valid test case as well

* Add missing RecipeBundleResolver import to PythonRewriteRpc

---------

Co-authored-by: Shannon Pamperl <shannon@moderne.io>
Co-authored-by: Shannon Pamperl <shanman190@gmail.com>
Co-authored-by: Jonathan Schneider <jkschneider@gmail.com>

Author: 3 people

rewrite-core/src/test/java/org/openrewrite/rpc/RewriteRpcTest.java

@@ -26,6 +26,7 @@
 import org.junit.jupiter.api.Test;
 import org.openrewrite.*;
 import org.openrewrite.config.Environment;
+import org.openrewrite.config.OptionDescriptor;
 import org.openrewrite.config.RecipeDescriptor;
 import org.openrewrite.internal.RecipeLoader;
 import org.openrewrite.marketplace.*;

rewrite-javascript/src/main/java/org/openrewrite/javascript/rpc/JavaScriptRewriteRpc.java

@@ -22,6 +22,7 @@
 import org.openrewrite.Parser;
 import org.openrewrite.SourceFile;
 import org.openrewrite.internal.StringUtils;
+import org.openrewrite.marketplace.RecipeBundleResolver;
 import org.openrewrite.marketplace.RecipeMarketplace;
 import org.openrewrite.rpc.RewriteRpc;
 import org.openrewrite.rpc.RewriteRpcProcess;
@@ -57,8 +58,8 @@ public class JavaScriptRewriteRpc extends RewriteRpc {
     private final Map<String, String> commandEnv;
     private final RewriteRpcProcess process;
 
-    JavaScriptRewriteRpc(RewriteRpcProcess process, RecipeMarketplace marketplace, String command, Map<String, String> commandEnv) {
-        super(process.getRpcClient(), marketplace);
+    JavaScriptRewriteRpc(RewriteRpcProcess process, RecipeMarketplace marketplace, List<RecipeBundleResolver> resolvers, String command, Map<String, String> commandEnv) {
+        super(process.getRpcClient(), marketplace, resolvers);
         this.command = command;
         this.commandEnv = commandEnv;
         this.process = process;
@@ -199,6 +200,7 @@ public static Builder builder() {
     @RequiredArgsConstructor
     public static class Builder implements Supplier<JavaScriptRewriteRpc> {
         private RecipeMarketplace marketplace = new RecipeMarketplace();
+        private List<RecipeBundleResolver> resolvers = Collections.emptyList();
         private final Map<String, String> environment = new HashMap<>();
         private Path npxPath = System.getProperty("os.name").toLowerCase().contains("windows") ? Paths.get("npx.cmd") : Paths.get("npx");
         private @Nullable Path log;
@@ -218,6 +220,11 @@ public Builder marketplace(RecipeMarketplace marketplace) {
             return this;
         }
 
+        public Builder resolvers(List<RecipeBundleResolver> resolvers) {
+            this.resolvers = resolvers;
+            return this;
+        }
+
         public Builder recipeInstallDir(@Nullable Path recipeInstallDir) {
             this.recipeInstallDir = recipeInstallDir;
             return this;
@@ -382,7 +389,7 @@ public JavaScriptRewriteRpc get() {
             process.start();
 
             try {
-                return (JavaScriptRewriteRpc) new JavaScriptRewriteRpc(process, marketplace,
+                return (JavaScriptRewriteRpc) new JavaScriptRewriteRpc(process, marketplace, resolvers,
                         String.join(" ", cmdArr), process.environment())
                         .livenessCheck(process::getLivenessCheck)
                         .timeout(timeout)

rewrite-python/src/main/java/org/openrewrite/python/rpc/PythonRewriteRpc.java

@@ -19,6 +19,7 @@
 import lombok.RequiredArgsConstructor;
 import org.jspecify.annotations.Nullable;
 import org.openrewrite.*;
+import org.openrewrite.marketplace.RecipeBundleResolver;
 import org.openrewrite.marketplace.RecipeMarketplace;
 import org.openrewrite.python.*;
 import org.openrewrite.python.marker.PythonResolutionResult;
@@ -63,8 +64,8 @@ public class PythonRewriteRpc extends RewriteRpc {
     private final Map<String, String> commandEnv;
     private final RewriteRpcProcess process;
 
-    PythonRewriteRpc(RewriteRpcProcess process, RecipeMarketplace marketplace, String command, Map<String, String> commandEnv) {
-        super(process.getRpcClient(), marketplace);
+    PythonRewriteRpc(RewriteRpcProcess process, RecipeMarketplace marketplace, List<RecipeBundleResolver> resolvers, String command, Map<String, String> commandEnv) {
+        super(process.getRpcClient(), marketplace, resolvers);
         this.command = command;
         this.commandEnv = commandEnv;
         this.process = process;
@@ -351,6 +352,7 @@ public static Builder builder() {
     @RequiredArgsConstructor
     public static class Builder implements Supplier<PythonRewriteRpc> {
         private RecipeMarketplace marketplace = new RecipeMarketplace();
+        private List<RecipeBundleResolver> resolvers = Collections.emptyList();
         private final Map<String, String> environment = new HashMap<>();
         // Default to looking for a venv python, falling back to system python
         private Path pythonPath = findDefaultPythonPath();
@@ -396,6 +398,11 @@ public Builder marketplace(RecipeMarketplace marketplace) {
             return this;
         }
 
+        public Builder resolvers(List<RecipeBundleResolver> resolvers) {
+            this.resolvers = resolvers;
+            return this;
+        }
+
         /**
          * Path to the Python executable.
          *
@@ -565,7 +572,7 @@ public PythonRewriteRpc get() {
             process.start();
 
             try {
-                return (PythonRewriteRpc) new PythonRewriteRpc(process, marketplace,
+                return (PythonRewriteRpc) new PythonRewriteRpc(process, marketplace, resolvers,
                         String.join(" ", cmdArr), process.environment())
                         .livenessCheck(process::getLivenessCheck)
                         .timeout(timeout)