C#: Populate Methods and Members on JavaType.Class#7072
Draft
knutwannheden wants to merge 2 commits intomainfrom
Draft
C#: Populate Methods and Members on JavaType.Class#7072knutwannheden wants to merge 2 commits intomainfrom
Methods and Members on JavaType.Class#7072knutwannheden wants to merge 2 commits intomainfrom
Conversation
CSharpTypeMapping.MapNamedType() was setting Methods and Members to null on every JavaType.Class, causing TypeUtils.HasMethod() to always return false. This broke recipe logic that checks method availability on types (e.g., checking if ArgumentNullException.ThrowIfNull exists for TFM compatibility). Now populates Methods (ordinary methods + constructors) and Members (non-implicit fields) by iterating symbol.GetMembers(). The existing shell cache pattern protects against infinite recursion from cyclic type references.
…ype.class-from-c-parser
knutwannheden
changed the title
Methods and Members on JavaType.Class
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CSharpTypeMapping.MapNamedType()was passingnullfor bothMethodsandMemberswhen constructingJavaType.Class, causingTypeUtils.HasMethod()to always returnfalsefor every typeMethods(ordinary methods + constructors) andMembers(non-implicit fields) from Roslyn'sINamedTypeSymbol.GetMembers()Context
This broke recipe logic in
recipes-csharpthat usesTypeUtils.HasMethod(type, "ThrowIfNull")to check whetherSystem.ArgumentNullExceptionsupportsThrowIfNull(a .NET 6+ API). BecauseMethodswas alwaysnull, the guard always returnedfalse, causing 5 test failures.Test plan
CSharpTypeMappingTests.ClassTypeShouldHaveMethods— verifiesThrowIfNullis found onArgumentNullExceptionCSharpTypeMappingTests.ClassTypeShouldHaveMethodsOnException— verifiesGetBaseExceptionis found onExceptionCSharpTypeMappingTests.UserDefinedClassShouldHaveMembers— verifies user-defined fields appear inMembers