Add visitArrayAccess to JavaPrinter for marker rendering#7129
Merged
Conversation
JavaPrinter was missing a visitArrayAccess override, which meant SearchResult markers on J.ArrayAccess nodes were not rendered during printing. Every other J node type had an explicit override that called beforeSyntax/afterSyntax (which renders markers), but ArrayAccess fell through to the base JavaVisitor.visitArrayAccess which doesn't call beforeSyntax.
timtebeek
approved these changes
Mar 24, 2026
github-project-automation
bot
moved this from In Progress
to Ready to Review
in OpenRewrite
sambsnyd
approved these changes
Mar 24, 2026
Member
|
Nice find! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
JavaPrinterwas missing avisitArrayAccessoverride, which meantSearchResultmarkers onJ.ArrayAccessnodes were never rendered during printingbeforeSyntax/afterSyntax(which renders markers), butArrayAccessfell through to the baseJavaVisitor.visitArrayAccesswhich doesn't callbeforeSyntaxitems[taintedIdx])