C#: Replace RewriteRule with CSharpTemplate.Rewrite()#7134
Merged
knutwannheden merged 1 commit intomainfrom Mar 25, 2026
Merged
C#: Replace RewriteRule with CSharpTemplate.Rewrite()#7134knutwannheden merged 1 commit intomainfrom
RewriteRule with CSharpTemplate.Rewrite()#7134knutwannheden merged 1 commit intomainfrom
Conversation
Consolidate the declarative pattern→template rewriting API into CSharpTemplate as static Rewrite() factory methods that directly return a CSharpVisitor<ExecutionContext>.
RewriteRule with CSharpTemplate.Rewrite()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The
IRewriteRule/RewriteRuleAPI was an intermediate abstraction between rawMatch/Applyand a full visitor. After simplifying it down to justTryOn()andToVisitor(), the remaining indirection doesn't carry its weight —ToVisitor()can be a static factory onCSharpTemplatedirectly, andTryOn()is justpat.Match()+tmpl.Apply()which is already clean enough in C#.Examples
Summary
IRewriteRuleinterface,RewriteRulestatic class, and all internal implementation classes (RewriteRuleImpl,RewriteRuleVisitor)CSharpTemplate.Rewrite()with three overloads: single pair, multiple patterns with shared template, and multiple (pattern, template) pairsCreateBlockFlattener<P>()andBlockFlattener<P>toCSharpTemplateMatch/ApplyTest plan
RewriteRuleTestspass with the new APIAttributeRenameViaRewriteRuleinTemplateApplyTestspassesIRewriteRule,RewriteRule,TryOn, orToVisitor