Skip to content

Docker: fixing an ANTLR warning#7237

Merged
greg-at-moderne merged 5 commits intomainfrom
greg-docker-antlr-case
Apr 2, 2026
Merged

Docker: fixing an ANTLR warning#7237
greg-at-moderne merged 5 commits intomainfrom
greg-docker-antlr-case

Conversation

@greg-at-moderne
Copy link
Copy Markdown
Contributor

@greg-at-moderne greg-at-moderne commented Apr 2, 2026 •
edited
Loading

What's changed?

  • Removing the redundant characters list, a-z is redundant over A-Z with case-insensitive ANTLR.
  • Also fixing the "// Generated from" comments normalization logic to work with Windows too.

What's your motivation?

I suddenly started getting this warning in IntelliJ (even if I didn't work with anything with ANTLR):

warning(180): DockerLexer.g4:92:12: chars a-z used multiple times in set [a-zA-Z]
warning(180): DockerLexer.g4:92:21: chars a-z used multiple times in set [a-zA-Z0-9_-]

This must've started after #7224.

@greg-at-moderne greg-at-moderne self-assigned this Apr 2, 2026
@github-project-automation github-project-automation bot moved this to In Progress in OpenRewrite Apr 2, 2026
@greg-at-moderne greg-at-moderne marked this pull request as ready for review April 2, 2026 07:58
@greg-at-moderne greg-at-moderne merged commit 26a0f3b into main Apr 2, 2026
1 check passed
@greg-at-moderne greg-at-moderne deleted the greg-docker-antlr-case branch April 2, 2026 07:58
@github-project-automation github-project-automation bot moved this from In Progress to Done in OpenRewrite Apr 2, 2026
@greg-at-moderne greg-at-moderne changed the title Docker: fixing a ANTLR warning Docker: fixing an ANTLR warning Apr 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@greg-at-moderne greg-at-moderne

Labels

docker

Projects

OpenRewrite
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@greg-at-moderne