fix: improve type guard correctness #35
Merged
+238
−206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves #30 .
stee-re
reviewed
Jun 18, 2025
| ); | ||
| } | ||
|
|
||
| export type EditEvent<E extends Edit = Edit> = CustomEvent<E>; |
Collaborator
There was a problem hiding this comment.
Why have you removed this? As I understand it, the only way we will see EditV1 objects is if they come from Plugins which have not yet made the switch, they will therefore come as events. If we're removing event support for EditV1, then everything else v1 related is probably superflous.
Would you consider restoring this and adding the associated:
declare global {
interface ElementEventMap {
['oscd-edit']: EditEvent;
}
}
I would very much like to support EditV1 in the shell for now. I'm all on for plastering depricated notices everywhere on this and adding console.warn()'s, but I'd very much like to make the adoption of oscd-shell, as friendly as is practical.
stee-re
reviewed
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, add OpenEvent.
Also, add some documentation.
Also, remove wizards from the markdown API doc.
Also, move utils to a separate module.
Also, expose the module members that were still missing.
Sorry for the big pull request.