fix: isSetAttribute to allow attr OR attrNS

.github/actions/setup-node-env/action.yml

@@ -24,26 +24,7 @@ runs:
           node_modules
         key: modules-${{ hashFiles('package-lock.json') }}
 
-    - name: Cache Playwright Binaries
-      id: cache-playwright
-      uses: actions/cache@v4
-      with:
-        path: |
-          ~/.cache/ms-playwright
-        key: playwright-${{ hashFiles('package-lock.json') }}
-
     - name: Install dependencies
       if: steps.cache-node-modules.outputs.cache-hit != 'true'
       run: npm ci
       shell: bash
-
-    - name: Install playwright browsers
-      if: steps.cache-playwright.outputs.cache-hit != 'true'
-      run: npx playwright install --with-deps
-      shell: bash
-
-    - name: Install system dependencies for WebKit
-      # Some WebKit dependencies seem to lay outside the cache and will need to be installed separately
-      if: steps.cache-playwright.outputs.cache-hit == 'true'
-      run: npx playwright install-deps webkit
-      shell: bash

.github/workflows/test.yml

@@ -4,6 +4,10 @@ on: [push, pull_request, workflow_dispatch]
 jobs:
   test:
     runs-on: ubuntu-latest
+    container:
+      image: mcr.microsoft.com/playwright:v1.50.1-noble
+      options: --user 1001
+
     steps:
       - name: Checkout
         uses: actions/checkout@v4

editv2.spec.ts

@@ -14,7 +14,12 @@ const element = new DOMParser().parseFromString(
   'application/xml',
 )!.documentElement;
 
-const update: Update = { element, attributes: {} };
+const update: Update = {
+  element,
+  attributes: {
+    attr1: { namespaceURI: 'http://myns.com', value: 'new value' },
+  },
+};
 const insert: Insert = { parent: element, node: element, reference: null };
 const remove: Remove = { node: element };
 const setAttributes: SetAttributes = {

editv2.ts

@@ -81,10 +81,11 @@ export function isRemove(edit: unknown): edit is Remove {
 }
 
 export function isSetAttributes(edit: unknown): edit is SetAttributes {
+  const setAttrs = edit as SetAttributes;
   return (
-    (edit as SetAttributes).element instanceof Element &&
-    isAttributesV2((edit as SetAttributes).attributes) &&
-    isAttributesNS((edit as SetAttributes).attributesNS)
+    setAttrs.element instanceof Element &&
+    (isAttributesV2(setAttrs.attributes) ||
+      isAttributesNS(setAttrs.attributesNS))
   );
 }
 

package.json

@@ -82,9 +82,9 @@
   },
   "lint-staged": {
     "*.ts": [
-      "eslint --fix --config package.json",
+      "eslint --fix",
       "prettier --write",
-      "eslint --config package.json"
+      "eslint"
     ]
   }
 }