Skip to content

Delete quotes in/around CVMFSEXEC_REPOS#183

Merged
matyasselmeci merged 3 commits intoopensciencegrid:masterfrom
matyasselmeci:pr/unquote
Feb 20, 2025
Merged

Delete quotes in/around CVMFSEXEC_REPOS#183
matyasselmeci merged 3 commits intoopensciencegrid:masterfrom
matyasselmeci:pr/unquote

Conversation

@matyasselmeci
Copy link
Contributor

People passing in env vars via a docker --env-file may be surprised to learn that quotes are passed through literally. Handle that case by just deleting the quotes.

People passing in env vars via a docker --env-file may be surprised to learn
that quotes are passed through literally.  Handle that case by just deleting
the quotes.
@matyasselmeci matyasselmeci requested a review from rynge February 19, 2025 19:39
Copy link
Member

@rynge rynge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…neration (globbing) and word splitting are _not_ performed on the variable in herestrings (`<<<`)
@matyasselmeci matyasselmeci merged commit a30b2b5 into opensciencegrid:master Feb 20, 2025
17 checks passed
@matyasselmeci matyasselmeci deleted the pr/unquote branch February 20, 2025 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments