Skip to content

Conversation

@joshuali925
Copy link
Member

@joshuali925 joshuali925 commented Nov 11, 2025

Description

Fix #10690 (comment)

appName is coming from context, which is created from props. removing appName makes services.appName undefined

Issues Resolved

Screenshot

Testing the changes

Changelog

  • skip

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@github-actions
Copy link
Contributor

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

@github-actions
Copy link
Contributor

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

@github-actions github-actions bot added Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry and removed failed changeset labels Nov 11, 2025
@codecov
Copy link

codecov bot commented Nov 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.76%. Comparing base (42e9595) to head (28e060f).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10903   +/-   ##
=======================================
  Coverage   60.76%   60.76%           
=======================================
  Files        4533     4533           
  Lines      122164   122171    +7     
  Branches    20471    20472    +1     
=======================================
+ Hits        74232    74239    +7     
  Misses      42695    42695           
  Partials     5237     5237           
Flag Coverage Δ
Linux_1 26.57% <ø> (-0.01%) ⬇️
Linux_2 38.92% <ø> (ø)
Linux_3 39.43% <ø> (+<0.01%) ⬆️
Linux_4 33.75% <ø> (-0.01%) ⬇️
Windows_1 26.58% <ø> (-0.01%) ⬇️
Windows_2 38.90% <ø> (ø)
Windows_3 39.44% <ø> (+<0.01%) ⬆️
Windows_4 33.75% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

distinguished-contributor Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants