-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add a dashboard breadcrumb when user naviagte from dashboard #10904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Joey Liu <[email protected]>
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10904 +/- ##
==========================================
- Coverage 60.76% 60.75% -0.01%
==========================================
Files 4533 4532 -1
Lines 122164 122206 +42
Branches 20471 20483 +12
==========================================
+ Hits 74232 74250 +18
- Misses 42695 42716 +21
- Partials 5237 5240 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Yulong Ruan <[email protected]>
src/plugins/explore/public/application/utils/hooks/use_page_initialization.ts
Outdated
Show resolved
Hide resolved
src/plugins/explore/public/utils/get_previous_page_breadcrumb.ts
Outdated
Show resolved
Hide resolved
src/plugins/explore/public/utils/get_previous_page_breadcrumb.ts
Outdated
Show resolved
Hide resolved
|
|
||
| // Check if the current URL has a workspace ID and the previous page link doesn't | ||
| const currentPathname = window.location.pathname; | ||
| const workspaceMatch = currentPathname.match(/\/w\/([^/]+)\//); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure how reliable this is in the future, does workspace have API to get id?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@joshuali925 yes, workspace has API to get the current workspace id
9cd3d5f
Signed-off-by: Joey Liu <[email protected]>
Description
Summary
Implement dynamic breadcrumbs in Explore plugin that navigate users back to the page they came from dashboard, providing better navigation context.
Changes
Smart Breadcrumb Navigation
Implementation Details
Issues Resolved
Screenshot
Screen.Recording.2025-11-11.at.4.40.39.PM.mp4
Testing the changes
Changelog
Check List
yarn test:jestyarn test:jest_integration