[Explore Vis]Simplify threshold logic #10909
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Qxisylolo <[email protected]>
Signed-off-by: Qxisylolo <[email protected]>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #10909 +/- ##
=======================================
Coverage 60.75% 60.76%
=======================================
Files 4533 4533
Lines 122206 122229 +23
Branches 20481 20491 +10
=======================================
+ Hits 74246 74267 +21
- Misses 42719 42722 +3
+ Partials 5241 5240 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Qxisylolo
requested review from
AMoo-Miki,
BionIT,
Flyingliuhub,
LDrago27,
SuZhou-Joe,
ZilongX,
abbyhu2000,
ananzh,
ashwin-pc,
bandinib-amzn,
curq,
joshuali925,
joshuarrrr,
kavilla,
manasvinibs,
mengweieric,
ruanyl,
sejli,
virajsanghvi,
xinruiba,
zengyan-amazon,
zhongnansu and
zhyuanqi
as code owners
Qxisylolo
requested review from
Maosaic,
TackAdam,
angle943,
d-buckner,
huyaboo,
paulstn,
ps48,
raintygao,
ruchidh,
sumukhswamy and
wanglam
as code owners
ruanyl
reviewed
Nov 13, 2025
| const newThreshold = threshold ?? []; | ||
|
|
||
| const newBaseColor = baseColor ?? getColors().statusGreen; | ||
| if (calculatedValue === undefined || calculatedValue < minBase) { |
Member
There was a problem hiding this comment.
It seems we don't consider maxBase, I'm just thinking shall we also not consider minBase to make it consistent? so just make the text color solely based on thresholds.
| result.unshift({ value: minBase, color: defaultColor }); | ||
| } | ||
|
|
||
| const valueResults: Threshold[] = []; |
Member
There was a problem hiding this comment.
I would create another function to calculate the valueResults separately
Signed-off-by: Yulong Ruan <[email protected]>
ruanyl
previously approved these changes
Nov 14, 2025
Signed-off-by: Qxisylolo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
this pr simplifies threshold logic
Issues Resolved
Screenshot
Testing the changes
Changelog
Check List
yarn test:jestyarn test:jest_integration