Skip to content

Conversation

@ruanyl
Copy link
Member

@ruanyl ruanyl commented Nov 14, 2025

Description

Instead of mapping the fields to name like field-0, field-2, etc, this change ensures that nested field names like 'machine.os' and 'data[0]' are properly handled in Vega-Lite visualizations by normalizing them to 'machine_os' and 'data(0)' respectively while still maintain the human readability.

Issues Resolved

Screenshot

Testing the changes

Changelog

  • refactor: implement field normalization for Vega-Lite compatibility

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Instead of mapping the fields to name like `field-0`, `field-2`, etc,
this change ensures that nested field names like 'machine.os' and 'data[0]'
are properly handled in Vega-Lite visualizations by normalizing them to
'machine_os' and 'data(0)' respectively so that they still human
readable.

Signed-off-by: Yulong Ruan <[email protected]>
@codecov
Copy link

codecov bot commented Nov 14, 2025

Codecov Report

❌ Patch coverage is 37.50000% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.75%. Comparing base (06a1ba8) to head (01d9b17).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...blic/components/visualizations/table/table_vis.tsx 20.00% 4 Missing ⚠️
...ents/visualizations/utils/normalize_result_rows.ts 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10917      +/-   ##
==========================================
- Coverage   60.75%   60.75%   -0.01%     
==========================================
  Files        4533     4534       +1     
  Lines      122206   122211       +5     
  Branches    20481    20484       +3     
==========================================
- Hits        74246    74244       -2     
- Misses      42719    42726       +7     
  Partials     5241     5241              
Flag Coverage Δ
Linux_1 26.57% <ø> (+<0.01%) ⬆️
Linux_2 38.92% <ø> (ø)
Linux_3 39.44% <ø> (+<0.01%) ⬆️
Linux_4 33.74% <37.50%> (+<0.01%) ⬆️
Windows_1 ?
Windows_2 38.90% <ø> (ø)
Windows_3 39.44% <ø> (+<0.01%) ⬆️
Windows_4 33.74% <37.50%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant