Skip to content

Conversation

@yyfamazon
Copy link
Contributor

@yyfamazon yyfamazon commented Dec 24, 2025

Description

Fix dangerous Functions:dangerouslySetInnerHTML

Issues Resolved

Screenshot

Testing the changes

Changelog

  • fix: Fix dangerous Functions:dangerouslySetInnerHTML

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@github-actions
Copy link
Contributor

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

@yyfamazon yyfamazon requested a review from SuZhou-Joe January 15, 2026 03:39
@github-actions
Copy link
Contributor

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

SuZhou-Joe
SuZhou-Joe previously approved these changes Jan 19, 2026
@github-actions
Copy link
Contributor

❌ Changelog Entry Missing Hyphen

Changelog entries must begin with a hyphen (-).

@wanglam
Copy link
Collaborator

wanglam commented Jan 19, 2026

Hi @yyfamazon, could you help fix the failed CI jobs? They seem to be related to dependency changes causing different build logs. We should fix these before merging.

Signed-off-by: yyfamazon <[email protected]>
@github-actions
Copy link
Contributor

❌ Changelog Entry Missing Hyphen

Changelog entries must begin with a hyphen (-).

@SuZhou-Joe
Copy link
Member

@yyfamazon , seems 7c7c6ac override the changeset file, could you please bring that file back?

Signed-off-by: yyfamazon <[email protected]>
wanglam
wanglam previously approved these changes Jan 19, 2026
@yyfamazon
Copy link
Contributor Author

**SuZhou-Joe **

@SuZhou-Joe
I already bring that file back. Sorry I thought add the changelog in PR description is enough.

@yyfamazon yyfamazon requested a review from SuZhou-Joe January 19, 2026 07:56
@SuZhou-Joe
Copy link
Member

@SuZhou-Joe I already bring that file back. Sorry I thought add the changelog in PR description is enough.

When you added a change log entry in the description, a bot will create a changeset file for you automatically. You should keep that file for your PR.

opensearch-changeset-bot bot added a commit to yyfamazon/OpenSearch-Dashboards that referenced this pull request Jan 19, 2026
opensearch-changeset-bot bot added a commit to yyfamazon/OpenSearch-Dashboards that referenced this pull request Jan 19, 2026
Signed-off-by: yyfamazon <[email protected]>
@abbyhu2000 abbyhu2000 merged commit 1d78029 into opensearch-project:main Jan 20, 2026
84 of 85 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants