Skip to content

chore: fix missing opensearch-sql depedency when running#11122

Open
Bigpet wants to merge 1 commit intoopensearch-project:mainfrom
Bigpet:feature/fix_opensearch_sql_plugin
Open

chore: fix missing opensearch-sql depedency when running#11122
Bigpet wants to merge 1 commit intoopensearch-project:mainfrom
Bigpet:feature/fix_opensearch_sql_plugin

Conversation

@Bigpet
Copy link

@Bigpet Bigpet commented Jan 3, 2026

Description

Fix missing opensearch-sql depedency when running
yarn opensearch snapshot --sql

Issues Resolved

running yarn opensearch snapshot --sql is not loading opensearch-sql successfully

Screenshot

no visible change

Testing the changes

run yarn opensearch snapshot --sql and look for

before:

   │ info Installing OpenSearch Plugin from the path: https://ci.opensearch.org/ci/dbc/distribution-build-opensearch/3.5.0/latest/linux/x64/tar/builds/opensearch/plugins/opensearch-sql-3.5.0.0.zip
   │ warn Failed to setup: opensearch-sql

after:

   │ info Installing OpenSearch Plugin from the path: https://ci.opensearch.org/ci/dbc/distribution-build-opensearch/3.5.0/latest/linux/x64/tar/builds/opensearch/plugins/opensearch-sql-3.5.0.0.zip
   │ info Plugin installation complete

Changelog

  • skip

Check List

  • All tests pass
    • yarn test:jest (same ones fail locally that failed before)
    • yarn test:jest_integration
  • New functionality includes testing. (no new functionality)
  • New functionality has been documented. (no new functionality)
  • Update CHANGELOG.md (no new functionality)
  • Commits are signed per the DCO using --signoff

Summary by CodeRabbit

  • New Features
    • Integrated the OpenSearch Job Scheduler plugin into cluster setup; it is now installed as part of startup, prior to the SQL and observability plugins.

✏️ Tip: You can customize this high-level summary in your review settings.

@github-actions github-actions bot added first-time-contributor Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry labels Jan 3, 2026
@coderabbitai
Copy link

coderabbitai bot commented Jan 3, 2026

📝 Walkthrough

Walkthrough

A plugin installation step was added to Cluster.setupSql to install opensearch-job-scheduler before the existing opensearch-sql and opensearch-observability plugin installations. No public signatures were changed.

Changes

Cohort / File(s) Summary
Plugin Installation Sequence
packages/osd-opensearch/src/cluster.js
Inserted installSqlPlugin('opensearch-job-scheduler') at the start of setupSql, making the installation order: job-scheduler → sql → observability.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 A rabbit hops through code so bright,
A scheduler springs into the night,
It queues the jobs with gentle cheer,
Then SQL and observability appear,
Hooray—deployments hum in flight! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: fixing a missing opensearch-sql dependency when running the snapshot command with SQL flag.
Description check ✅ Passed The description includes all essential sections: clear description of the problem, related issue context, before/after testing results, and appropriate checklist completion for a chore without new functionality.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings

📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1874b68 and a4dd822.

📒 Files selected for processing (1)
  • packages/osd-opensearch/src/cluster.js
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/osd-opensearch/src/cluster.js

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Jan 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.36%. Comparing base (fd071f1) to head (a4dd822).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11122      +/-   ##
==========================================
- Coverage   60.36%   60.36%   -0.01%     
==========================================
  Files        4591     4591              
  Lines      126397   126397              
  Branches    21183    21183              
==========================================
- Hits        76296    76295       -1     
- Misses      44687    44688       +1     
  Partials     5414     5414              
Flag Coverage Δ
Linux_1 26.36% <ø> (ø)
Linux_2 38.27% <ø> (ø)
Linux_3 39.80% <ø> (ø)
Linux_4 33.31% <ø> (ø)
Windows_1 26.37% <ø> (-0.01%) ⬇️
Windows_2 38.25% <ø> (ø)
Windows_3 39.80% <ø> (-0.01%) ⬇️
Windows_4 33.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Bigpet
Copy link
Author

Bigpet commented Jan 4, 2026

ran the failing test locally (took me like an hour to figure out how) and it works locally, so it seems like a flaky test.

`yarn opensearch snapshot --sql`

Signed-off-by: Peter Tissen <dravorek@gmail.com>
@Bigpet Bigpet force-pushed the feature/fix_opensearch_sql_plugin branch from 1874b68 to a4dd822 Compare January 4, 2026 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

first-time-contributor Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants