chore: fix missing opensearch-sql depedency when running#11122
chore: fix missing opensearch-sql depedency when running#11122Bigpet wants to merge 1 commit intoopensearch-project:mainfrom
Conversation
📝 WalkthroughWalkthroughA plugin installation step was added to Cluster.setupSql to install Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
📜 Recent review detailsConfiguration used: defaults Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #11122 +/- ##
==========================================
- Coverage 60.36% 60.36% -0.01%
==========================================
Files 4591 4591
Lines 126397 126397
Branches 21183 21183
==========================================
- Hits 76296 76295 -1
- Misses 44687 44688 +1
Partials 5414 5414
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
ran the failing test locally (took me like an hour to figure out how) and it works locally, so it seems like a flaky test. |
`yarn opensearch snapshot --sql` Signed-off-by: Peter Tissen <dravorek@gmail.com>
1874b68 to
a4dd822
Compare
Description
Fix missing opensearch-sql depedency when running
yarn opensearch snapshot --sqlIssues Resolved
running
yarn opensearch snapshot --sqlis not loading opensearch-sql successfullyScreenshot
no visible change
Testing the changes
run
yarn opensearch snapshot --sqland look forbefore:
after:
Changelog
Check List
yarn test:jest(same ones fail locally that failed before)yarn test:jest_integrationNew functionality includes testing.(no new functionality)New functionality has been documented.(no new functionality)Update CHANGELOG.md(no new functionality)Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.