[chore]Update node to 22.21.1#11126
Draft
wanglam wants to merge 2 commits intoopensearch-project:feature/node-22-webpack-5from
Draft
[chore]Update node to 22.21.1#11126wanglam wants to merge 2 commits intoopensearch-project:feature/node-22-webpack-5from
wanglam wants to merge 2 commits intoopensearch-project:feature/node-22-webpack-5from
Conversation
Signed-off-by: Lin Wang <wonglam@amazon.com>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feature/node-22-webpack-5 #11126 +/- ##
==========================================================
Coverage 60.36% 60.37%
==========================================================
Files 4591 4591
Lines 126396 126397 +1
Branches 21183 21183
==========================================================
+ Hits 76295 76307 +12
+ Misses 44687 44675 -12
- Partials 5414 5415 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR upgrades Node.js from version 20.18.3 to 22.21.1 to keep OpenSearch Dashboards aligned with the latest LTS Node.js version. The upgrade includes updating version files (
.node-version,.nvmrc) and adjusting the Node.js engine requirement inpackage.jsonfrom<21to<23.To ensure compatibility with Node.js 22, several changes were made: updated stream
destroy()method signatures to properly invoke callbacks as required by Node.js 22, suppressed new deprecation warnings (MODULE_TYPELESS_PACKAGE_JSONandfs.Stats constructor), updated test snapshots to account for Node.js 22 output changes, and addedchto Mocha's global variables whitelist. All existing tests pass with the new Node.js version.Issues Resolved
A part of #11080
Changelog
Check List
yarn test:jestyarn test:jest_integration