Fix IndexOutOfBoundsException when running include/exclude with non-existent prefix term

[harshavamsi]

Description

As described in #19636, we check the bounds of the ordinal before we seek

Related Issues

Resolves #19636

Check List

• Functionality includes testing.
• API changes companion pull request created, if applicable.
• Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[harshavamsi]

@msfroh could you take a look since you added this optimization

[msfroh]

Thanks for fixing this!

[github-actions]

❌ Gradle check result for 7f1e867: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

✅ Gradle check result for 7f1e867: SUCCESS

[codecov]

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 72.99%. Comparing base (252cff8) to head (7f1e867).
⚠️ Report is 7 commits behind head on main.

Files with missing lines	Patch %	Lines
...arch/aggregations/bucket/terms/IncludeExclude.java	66.66%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #19637      +/-   ##
============================================
- Coverage     73.11%   72.99%   -0.12%     
+ Complexity    70661    70638      -23     
============================================
  Files          5724     5725       +1     
  Lines        323498   323739     +241     
  Branches      46852    46882      +30     
============================================
- Hits         236518   236326     -192     
- Misses        67846    68330     +484     
+ Partials      19134    19083      -51     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[asimmahmood1]

Since this feature was released in 3.0.0, should backport to 3.1, 3.2, 3.3?

[harshavamsi]

yes we should backport this to 3.x since we will release only 3.4 moving forward, no need to backport to 3.x

[github-actions]

❌ Gradle check result for e160c63: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?