-
Notifications
You must be signed in to change notification settings - Fork 2.3k
[GRPC] Add separate grpc.detailed_errors.enabled error handling setting for gRPC #19644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[GRPC] Add separate grpc.detailed_errors.enabled error handling setting for gRPC #19644
Conversation
…setting for gRPC Signed-off-by: Sergei Ustimenko <[email protected]>
Signed-off-by: Sergei Ustimenko <[email protected]>
❌ Gradle check result for 702f7d9: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Sergei Ustimenko <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #19644 +/- ##
============================================
+ Coverage 72.96% 73.10% +0.13%
+ Complexity 70655 70654 -1
============================================
Files 5725 5725
Lines 323697 323707 +10
Branches 46875 46875
============================================
+ Hits 236198 236636 +438
+ Misses 68436 67948 -488
- Partials 19063 19123 +60 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Sergei Ustimenko <[email protected]>
❌ Gradle check result for 9b42790: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Looks like a failure due to a flaky test, more here: #14312 |
Description
This PR introduces a new setting
grpc.detailed_errors.enabled
(much like the similar http flag.)This way gRPC APIs would have the same semantics when using the global
error_trace
request parameter once it is implemented.Related Issues
Resolves #19639
Check List
Please note, that I haven't yet created the public documentation issue/PR for this setting as first I wanted to give this PR a go, get more feedback and then create the corresponding issue/PR.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.