-
Notifications
You must be signed in to change notification settings - Fork 2.3k
[Java Agent] Allow JRT protocol URLs in protection domain extraction #19683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[Java Agent] Allow JRT protocol URLs in protection domain extraction #19683
Conversation
Signed-off-by: rithin-pullela-aws <[email protected]>
Signed-off-by: rithin-pullela-aws <[email protected]>
❌ Gradle check result for 5b1a49f: null Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Re-ran the CI. Jenkins didn't pick it up on the first try. |
@getsaurabh02 @peterzhuamazon Can this be included in the 3.3.1 patch release? @owaiskazi19 @rithin-pullela-aws to provide impact on ml-commons. In some distributions, agentic search is hitting issues with the java agent due to this. See opensearch-project/ml-commons#4209 |
.../agent/src/test/java/org/opensearch/javaagent/StackCallerProtectionDomainExtractorTests.java
Outdated
Show resolved
Hide resolved
❌ Gradle check result for 5b1a49f: null Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
This PR is to solve this issue opensearch-project/ml-commons#4209 right ? Not opensearch-project/ml-commons#4194 |
Yes, updated the description |
Signed-off-by: rithin-pullela-aws <[email protected]>
❌ Gradle check result for 52a614f: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 52a614f: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Need to fix the compiler warnings. These are due to the test added in the PR.
You can fix by adding i.e. |
Description
jrt:
protocol URLs inStackCallerProtectionDomainChainExtractor
testFiltersJrtProtocolWithoutMockito()
to verify the filtering behaviorRelated Issues
Resolves opensearch-project/ml-commons#4209
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.