Skip to content

Conversation

rithin-pullela-aws
Copy link

@rithin-pullela-aws rithin-pullela-aws commented Oct 18, 2025

Description

  • Add filtering for jrt: protocol URLs in StackCallerProtectionDomainChainExtractor
  • Added test case testFiltersJrtProtocolWithoutMockito() to verify the filtering behavior

Related Issues

Resolves opensearch-project/ml-commons#4209

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@rithin-pullela-aws rithin-pullela-aws requested a review from a team as a code owner October 18, 2025 06:41
Signed-off-by: rithin-pullela-aws <[email protected]>
Copy link
Contributor

❌ Gradle check result for 5b1a49f: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@cwperks
Copy link
Member

cwperks commented Oct 18, 2025

Re-ran the CI. Jenkins didn't pick it up on the first try.

@cwperks
Copy link
Member

cwperks commented Oct 18, 2025

@getsaurabh02 @peterzhuamazon Can this be included in the 3.3.1 patch release?

@owaiskazi19 @rithin-pullela-aws to provide impact on ml-commons. In some distributions, agentic search is hitting issues with the java agent due to this. See opensearch-project/ml-commons#4209

Copy link
Contributor

❌ Gradle check result for 5b1a49f: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@ylwu-amzn
Copy link
Contributor

This PR is to solve this issue opensearch-project/ml-commons#4209 right ? Not opensearch-project/ml-commons#4194

@owaiskazi19
Copy link
Member

owaiskazi19 commented Oct 18, 2025

This PR is to solve this issue opensearch-project/ml-commons#4209 right ? Not opensearch-project/ml-commons#4194

Yes, updated the description

@github-actions github-actions bot added the backport PRs or issues specific to backporting features or enhancments label Oct 18, 2025
Signed-off-by: rithin-pullela-aws <[email protected]>
Copy link
Contributor

❌ Gradle check result for 52a614f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@owaiskazi19 owaiskazi19 added the backport 3.3 Backport to 3.3 branch label Oct 18, 2025
Copy link
Contributor

❌ Gradle check result for 52a614f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@cwperks
Copy link
Member

cwperks commented Oct 18, 2025

Need to fix the compiler warnings. These are due to the test added in the PR.

 [3.3.0] > Task :libs:agent-sm:agent:compileJava
 [3.3.0] /home/ubuntu/.gradle/caches/modules-2/files-2.1/net.bytebuddy/byte-buddy/1.17.7/3856bfab61beb23e099a0d6629f2ba8de4b98ace/byte-buddy-1.17.7.jar(/net/bytebuddy/implementation/bytecode/assign/Assigner.class): warning: Cannot find annotation method 'value()' in type 'SuppressFBWarnings': class file for edu.umd.cs.findbugs.annotations.SuppressFBWarnings not found
 [3.3.0] /home/ubuntu/.gradle/caches/modules-2/files-2.1/net.bytebuddy/byte-buddy/1.17.7/3856bfab61beb23e099a0d6629f2ba8de4b98ace/byte-buddy-1.17.7.jar(/net/bytebuddy/implementation/bytecode/assign/Assigner.class): warning: Cannot find annotation method 'justification()' in type 'SuppressFBWarnings'
 [3.3.0] /home/ubuntu/.gradle/caches/modules-2/files-2.1/net.bytebuddy/byte-buddy/1.17.7/3856bfab61beb23e099a0d6629f2ba8de4b98ace/byte-buddy-1.17.7.jar(/net/bytebuddy/description/type/TypeDescription$ForLoadedType.class): warning: Cannot find annotation method 'value()' in type 'SuppressFBWarnings'
 [3.3.0] /home/ubuntu/.gradle/caches/modules-2/files-2.1/net.bytebuddy/byte-buddy/1.17.7/3856bfab61beb23e099a0d6629f2ba8de4b98ace/byte-buddy-1.17.7.jar(/net/bytebuddy/description/type/TypeDescription$ForLoadedType.class): warning: Cannot find annotation method 'justification()' in type 'SuppressFBWarnings'
...

You can fix by adding compileOnly dependency on spotbugs-annotations in libs/agent-sm/agent/build.gradle

i.e. compileOnly("com.github.spotbugs:spotbugs-annotations:4.9.7")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport PRs or issues specific to backporting features or enhancments backport 3.3 Backport to 3.3 branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Failed to get tools from external MCP server

4 participants