Skip to content

Disable Segment Replication Backpressure check for Warm Index #20116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Gagan6164 wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −1
Open

Disable Segment Replication Backpressure check for Warm Index #20116

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion server/src/main/java/org/opensearch/action/bulk/TransportShardBulkAction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -567,7 +567,7 @@ private void finishRequest() {

@Override
protected Releasable checkPrimaryLimits(BulkShardRequest request, boolean rerouteWasLocal, boolean localRerouteInitiatedByNodeClient) {
if (force(request) == false) {
if (force(request) == false && isWarmNode == false) {
if (segmentReplicationPressureService.isSegmentReplicationBackpressureEnabled()) {
segmentReplicationPressureService.isSegrepLimitBreached(request.shardId());
}
Expand Down
4 changes: 4 additions & 0 deletions ...r/src/main/java/org/opensearch/action/support/replication/TransportReplicationAction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,8 @@
import java.util.Objects;
import java.util.concurrent.atomic.AtomicBoolean;

import static org.opensearch.cluster.node.DiscoveryNode.isWarmNode;

/**
* Base class for requests that should be executed on a primary copy followed by replica copies.
* Subclasses can resolve the target shard and provide implementation for primary and replica operations.
Expand Down Expand Up @@ -151,6 +153,7 @@ public abstract class TransportReplicationAction<
protected final TransportRequestOptions transportOptions;
protected final String executor;
protected final boolean forceExecutionOnPrimary;
protected final boolean isWarmNode;

// package private for testing
protected final String transportReplicaAction;
Expand Down Expand Up @@ -253,6 +256,7 @@ protected TransportReplicationAction(
this.initialRetryBackoffBound = REPLICATION_INITIAL_RETRY_BACKOFF_BOUND.get(settings);
this.retryTimeout = getRetryTimeoutSetting().get(settings);
this.forceExecutionOnPrimary = forceExecutionOnPrimary;
this.isWarmNode = isWarmNode(settings);

transportService.registerRequestHandler(actionName, ThreadPool.Names.SAME, requestReader, this::handleOperationRequest);

Expand Down
Loading