Fix cleanup due to bug in Datafusion Reader not releasing catalog snapshot #20165
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
mgodwan
force-pushed
the
feature/datafusion
branch
from
28f2724 to
8801b6d
Compare
| @Override | ||
| public void close() { | ||
| readerHandle.close(); | ||
| releaseCatalogSnapshot(); |
There was a problem hiding this comment.
releaseCatalogSnapshot would be invoked as a part of ReaderHandle doClose already right, do we need them both?
There was a problem hiding this comment.
yes. removing this as it is not needed
|
❌ Gradle check result for 8801b6d: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
…pshot Signed-off-by: Mohit Godwani <[email protected]>
mgodwan
force-pushed
the
feature/datafusion
branch
from
8801b6d to
5cfc67b
Compare
|
❌ Gradle check result for 5cfc67b: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
bharath-techie
merged commit f42e790
into
opensearch-project:feature/datafusion
3 participants
…pshot
Description
[Describe what this change achieves]
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.