write FipsPlugin to configure all test-clusters #20166
Conversation
Signed-off-by: Igonin <[email protected]> Co-authored-by: Benny Goerzig <[email protected]> Co-authored-by: Karsten Schnitter <[email protected]> Co-authored-by: Kai Sternad <[email protected]>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
|
❌ Gradle check result for 2734b63: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
|
||
| // register cluster hooks | ||
| project.getRootProject().getPluginManager().apply(TestClustersHookPlugin.class); | ||
|
|
There was a problem hiding this comment.
Hm ... I think this is not the way we should be doing it, it is going to sneak into any test case that uses test clusters, we have two options here:
- add test project to https://github.com/opensearch-project/OpenSearch/tree/main/qa folder
- add example plugin to https://github.com/opensearch-project/OpenSearch/tree/main/plugins/examples
Please note that test clusters are used outside of the core and core plugins
3 participants
Description
Write FipsPlugin to configure all test-clusters
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.