Skip to content

Migrate KNNEngine interfaces#20537

Draft
ajleong623 wants to merge 4 commits intoopensearch-project:mainfrom
ajleong623:knn-interfaces-KNNMethod
Draft

Migrate KNNEngine interfaces#20537
ajleong623 wants to merge 4 commits intoopensearch-project:mainfrom
ajleong623:knn-interfaces-KNNMethod

Conversation

@ajleong623
Copy link
Contributor

@ajleong623 ajleong623 commented Feb 4, 2026

Description

Migrates some of the required interfaces from the KNN plugin to core, avoiding repeated work between different KNN plugin implementations.

Related Issues

#20050

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Anthony Leong <anthonyleong@Mac.hsd1.ca.comcast.net>
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 4, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.


Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2026

❌ Gradle check result for f1c9689: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@ajleong623 ajleong623 changed the title Migrate KNNMethod interfaces Migrate KNNEngine interfaces Feb 5, 2026
Signed-off-by: Anthony Leong <anthonyleong@Anthonys-MacBook-Air.local>
@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2026

❌ Gradle check result for 93014ad: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Anthony Leong added 2 commits February 10, 2026 13:22
Signed-off-by: Anthony Leong <anthonyleong@Anthonys-MacBook-Air.local>
Signed-off-by: Anthony Leong <anthonyleong@Anthonys-MacBook-Air.local>
@github-actions
Copy link
Contributor

❌ Gradle check result for db2fad8: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@opensearch-trigger-bot
Copy link
Contributor

This PR is stalled because it has been open for 30 days with no activity.

@opensearch-trigger-bot opensearch-trigger-bot bot added the stalled Issues that have stalled label Mar 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stalled Issues that have stalled

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant