Skip to content

Fix flaky testOverflowDisabledAsynchronous by throwing AlreadyClosedException #20848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrross merged 1 commit into from
Mar 12, 2026
Merged

Fix flaky testOverflowDisabledAsynchronous by throwing AlreadyClosedException #20848

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions server/src/main/java/org/opensearch/index/store/remote/utils/TransferManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@

import org.apache.logging.log4j.LogManager;
import org.apache.logging.log4j.Logger;
import org.apache.lucene.store.AlreadyClosedException;
import org.apache.lucene.store.IOContext;
import org.apache.lucene.store.IndexInput;
import org.opensearch.common.annotation.ExperimentalApi;
Expand Down Expand Up @@ -206,7 +207,7 @@ private DelayedCreationCachedIndexInput(FileCache fileCache, StreamReader stream
@Override
public IndexInput getIndexInput() throws IOException {
if (isClosed.get()) {
throw new IllegalStateException("Already closed");
throw new AlreadyClosedException("Already closed");
}
if (isStarted.getAndSet(true) == false) {
// We're the first one here, need to download the block
Expand All @@ -233,7 +234,7 @@ public IndexInput getIndexInput() throws IOException {
public CompletableFuture<IndexInput> asyncLoadIndexInput(Executor executor) {
if (isClosed.get()) {
fileCache.decRef(request.getFilePath());
return CompletableFuture.failedFuture(new IllegalStateException("Already closed"));
return CompletableFuture.failedFuture(new AlreadyClosedException("Already closed"));
}
if (isStarted.getAndSet(true) == false) {
// Create new future and set it as the result
Expand Down
Loading