Skip to content

Optimizing the memory consumption and Restructuring the Lucene Commit…#20895

Open
darjisagar7 wants to merge 1 commit intoopensearch-project:feature/datafusionfrom
darjisagar7:FinalCombineMergeRowId
Open

Optimizing the memory consumption and Restructuring the Lucene Commit…#20895
darjisagar7 wants to merge 1 commit intoopensearch-project:feature/datafusionfrom
darjisagar7:FinalCombineMergeRowId

Conversation

@darjisagar7
Copy link

… Engine

Description

[Describe what this change achieves]

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

… Engine

Signed-off-by: Sagar Darji <darjisagar7@gmail.com>
@github-actions
Copy link
Contributor

PR Code Analyzer ❗

AI-powered 'Code-Diff-Analyzer' found issues on commit 19d1395.

PathLineSeverityDescription
server/src/main/java/org/opensearch/index/engine/exec/lucene/engine/LuceneExecutionEngine.java30mediumPrintStreamInfoStream is imported but not visibly used in the diff. This class routes Lucene internal diagnostics (including index paths, segment names, merge details) to stdout/stderr. If wired up elsewhere or added later, it could leak internal index structure details to logs. Warrants verification that this import is intentional and the stream target is controlled.
server/src/main/java/org/opensearch/index/engine/exec/lucene/engine/LuceneExecutionEngine.java253lowThe close() method calls IOUtils.close(luceneCommitEngine.acquireSafeIndexCommit()) which closes a GatedCloseable snapshot rather than the underlying IndexWriter. The IndexWriter held inside LuceneCommitEngine is never closed, since the previous explicit close() that called IOUtils.close(indexWriter) was removed from LuceneCommitEngine. This is likely a bug rather than malicious intent, but could cause file handle exhaustion or data loss on shutdown.

The table above displays the top 10 most important findings.

Total: 2 | Critical: 0 | High: 0 | Medium: 1 | Low: 1


Pull Requests Author(s): Please update your Pull Request according to the report above.

Repository Maintainer(s): You can bypass diff analyzer by adding label skip-diff-analyzer after reviewing the changes carefully, then re-run failed actions. To re-enable the analyzer, remove the label, then re-run all actions.


⚠️ Note: The Code-Diff-Analyzer helps protect against potentially harmful code patterns. Please ensure you have thoroughly reviewed the changes beforehand.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant