Fix flaky Netty4Http3IT test suite (second attempt)#20900
Fix flaky Netty4Http3IT test suite (second attempt)#20900reta merged 1 commit intoopensearch-project:mainfrom
Conversation
PR Reviewer Guide 🔍(Review updated until commit 242500a)Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Latest suggestions up to 242500a Explore these optional code suggestions:
Previous suggestionsSuggestions up to commit 242500a
Suggestions up to commit 203a589
Suggestions up to commit 5b66523
Suggestions up to commit bd59477
Suggestions up to commit 982c852
|
|
❌ Gradle check result for ce6727b: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
Persistent review updated to latest commit 550a3b5 |
|
❌ Gradle check result for 550a3b5: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 550a3b5: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
Persistent review updated to latest commit 982c852 |
|
❌ Gradle check result for 982c852: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 982c852: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
4a9a15c to
bd59477
Compare
|
Persistent review updated to latest commit bd59477 |
|
❌ Gradle check result for bd59477: null Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for bd59477: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
Persistent review updated to latest commit 5b66523 |
|
❌ Gradle check result for 5b66523: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
Persistent review updated to latest commit 203a589 |
|
❌ Gradle check result for 203a589: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 203a589: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 203a589: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 203a589: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Andriy Redko <drreta@gmail.com>
|
Persistent review updated to latest commit 242500a |
|
❌ Gradle check result for 242500a: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #20900 +/- ##
============================================
+ Coverage 73.30% 73.83% +0.52%
- Complexity 72484 73026 +542
============================================
Files 5819 5819
Lines 331155 331353 +198
Branches 47840 47875 +35
============================================
+ Hits 242769 244659 +1890
+ Misses 68876 67538 -1338
+ Partials 19510 19156 -354 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
❌ Gradle check result for 242500a: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 242500a: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
Persistent review updated to latest commit 242500a |
|
❌ Gradle check result for 242500a: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
@andrross I highly suspect the changes in this pull request may not fix the issue but I have added some diagnostic info to capture what exactly could be the cause, it should help to work towards permanent fix (I sadly never was able to reproduce the issue). |
|
FYI @reta, I've had some success reproducing these hard-to-repro failures by running the test on a remote machine and then using |
Thanks @andrross, I did pursue similar paths as well (cutting active cpu count, disabling C1/C2, running many tests parallel at 100% CPU utilization), but literally no luck |
Signed-off-by: Andriy Redko <drreta@gmail.com> (cherry picked from commit a60cecd) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
Fix flaky Netty4Http3IT test suite (second attempt)
Related Issues
Investigates #20654
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.