Skip to content

Fix version for disable_objects bug tests#20956

Merged
andrross merged 1 commit intoopensearch-project:mainfrom
andrross:field-caps-version
Mar 22, 2026
Merged

Fix version for disable_objects bug tests#20956
andrross merged 1 commit intoopensearch-project:mainfrom
andrross:field-caps-version

Conversation

@andrross
Copy link
Member

Check List

  • Functionality includes testing.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Andrew Ross <andrross@amazon.com>
@andrross andrross requested a review from a team as a code owner March 22, 2026 00:07
@github-actions
Copy link
Contributor

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

🧪 PR contains tests
🔒 No security concerns identified
✅ No TODO sections
🔀 No multiple PR themes
⚡ Recommended focus areas for review

Version Range

The skip version is set to " - 3.5.99" with reason "Bug fixed in 3.6", but the upper bound should likely be " - 3.5.99" only if the fix is confirmed in 3.6.0. Verify that the bug fix is indeed included in 3.6.0 and not a later patch version, and that the version string format is consistent with other test files in the project.

version: " - 3.5.99"
reason: "Bug fixed in 3.6"

@andrross
Copy link
Member Author

See the build failure here: https://build.ci.opensearch.org/job/gradle-check/73026/testReport/

@newtonne Please correct me if I'm wrong but I believe this test will only reliably work with 3.6+ versions that have the fix.

@github-actions
Copy link
Contributor

✅ Gradle check result for 027ec93: SUCCESS

@codecov
Copy link

codecov bot commented Mar 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.28%. Comparing base (53c4fb7) to head (027ec93).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #20956      +/-   ##
============================================
+ Coverage     73.18%   73.28%   +0.09%     
- Complexity    72461    72463       +2     
============================================
  Files          5819     5819              
  Lines        331360   331360              
  Branches      47878    47878              
============================================
+ Hits         242495   242821     +326     
+ Misses        69389    68958     -431     
- Partials      19476    19581     +105     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@newtonne
Copy link
Contributor

@andrross Yeah, that’s right. Thanks for the fix. And thanks for the review on the other PR 👍

@andrross andrross merged commit fb5d661 into opensearch-project:main Mar 22, 2026
42 of 48 checks passed
@andrross andrross deleted the field-caps-version branch March 23, 2026 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants