Fix flaky NRTReplicationEngineTests segment count assertions#21044
Open
andrross wants to merge 1 commit intoopensearch-project:mainfrom
Open
Fix flaky NRTReplicationEngineTests segment count assertions#21044andrross wants to merge 1 commit intoopensearch-project:mainfrom
andrross wants to merge 1 commit intoopensearch-project:mainfrom
Conversation
The testAcquireLastIndexCommit and testGetSegmentInfosSnapshotPreservesFilesUntilRelease tests used generateHistoryOnReplica which randomly picks operation types and document IDs. With certain seeds, this produced DELETE/NO_OP operations or duplicate IDs with out-of-order seqNos, resulting in fewer segments than expected. The shared engine's random merge policy could also merge segments during refresh. Replace generateHistoryOnReplica with deterministic INDEX operations using distinct document IDs. Use a local primary engine with ForceMergePolicy to prevent automatic merges while still allowing the explicit forceMerge the tests require. Signed-off-by: Andrew Ross <andrross@amazon.com>
andrross
requested review from
a team,
Bukhtawar,
CEHENKLE,
Rishikesh1159,
anasalkouz,
ashking94,
cwperks,
dbwiddis,
gbbafna,
jed326,
kotwanikunal,
mch2,
msfroh,
owaiskazi19,
reta,
sachinpkale,
saratvemulapalli,
shwetathareja and
sohami
as code owners
github-actions
bot
added
>test-failure
Contributor
|
Failed to generate code suggestions for PR |
Contributor
|
❌ Gradle check result for 12049a9: null Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The testAcquireLastIndexCommit and
testGetSegmentInfosSnapshotPreservesFilesUntilRelease tests used generateHistoryOnReplica which randomly picks operation types and document IDs. With certain seeds, this produced DELETE/NO_OP operations or duplicate IDs with out-of-order seqNos, resulting in fewer segments than expected. The shared engine's random merge policy could also merge segments during refresh.
Replace generateHistoryOnReplica with deterministic INDEX operations using distinct document IDs. Use a local primary engine with ForceMergePolicy to prevent automatic merges while still allowing the explicit forceMerge the tests require.
This test would fail with the following seed:
Related Issues
Resolves #15817
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.