updating PublishFindingsRequest to use a list of findings rather than…#832
Merged
sbcd90 merged 2 commits intoopensearch-project:mainfrom Jun 11, 2025
Merged
updating PublishFindingsRequest to use a list of findings rather than…#832sbcd90 merged 2 commits intoopensearch-project:mainfrom
sbcd90 merged 2 commits intoopensearch-project:mainfrom
Conversation
toepkerd
requested review from
AWSHurneyt,
bowenlan-amzn,
eirsep,
engechas,
getsaurabh02,
jowg-amazon,
lezzago,
rishabhmaurya,
riysaxen-amzn and
sbcd90
as code owners
eirsep
previously approved these changes
Jun 10, 2025
sbcd90
previously approved these changes
Jun 10, 2025
… an individual one Signed-off-by: Dennis Toepker <toepkerd@amazon.com>
This reverts commit ad4d0c2. Signed-off-by: Dennis Toepker <toepkerd@amazon.com>
engechas
approved these changes
Jun 10, 2025
eirsep
approved these changes
Jun 11, 2025
eirsep
added a commit
to eirsep/common-utils
that referenced
this pull request
Jun 20, 2025
…her than… (opensearch-project#832) (opensearch-project#833)" This reverts commit f6756af. Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>
eirsep
added a commit
that referenced
this pull request
Jun 20, 2025
toepkerd
pushed a commit
to toepkerd/common-utils
that referenced
this pull request
Jul 9, 2025
…her than… (opensearch-project#832)" This reverts commit 774c00d.
5 tasks
toepkerd
pushed a commit
to toepkerd/common-utils
that referenced
this pull request
Jul 9, 2025
…her than… (opensearch-project#832)" This reverts commit 774c00d. Signed-off-by: Dennis Toepker <toepkerd@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updating PublishFindingsRequest to use a list of findings rather than an individual finding. This allows findings to be published in batches as opposed to individually.
Related Issues
opensearch-project/alerting#1859
opensearch-project/security-analytics#1537
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.