Fix APM metric card calculations and clean up Services Home labels#2624
Merged
ps48 merged 2 commits intoopensearch-project:mainfrom Mar 25, 2026
Merged
Fix APM metric card calculations and clean up Services Home labels#2624ps48 merged 2 commits intoopensearch-project:mainfrom
ps48 merged 2 commits intoopensearch-project:mainfrom
Conversation
Signed-off-by: ps48 <pshenoy36@gmail.com>
Signed-off-by: ps48 <pshenoy36@gmail.com>
ps48
commented
Mar 25, 2026
| }) => { | ||
| const { config } = useApmConfig(); | ||
| const windowDuration = config?.windowDuration ?? 60; | ||
| const { _config } = useApmConfig(); |
Member
Author
There was a problem hiding this comment.
This is a known unused variable, will fix it in follow up PR later.
joshuali925
approved these changes
Mar 25, 2026
TackAdam
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
showTotalmode summed all data points and divided by 1 instead of the number of data points. Fixed by defaulting the divisor tochartData.lengthwhen no explicit divisor is provided.sum_over_timeon histogram buckets to compute the true P99/P90/P50 over the full selected time range.getQueryAllOperationsFaultRateandgetQueryAllDependenciesFaultRatewere fetched but never rendered in the Operations or Dependencies tables. Removed to save 1 unnecessary Prometheus API call per tab.Issues Resolved
#2545
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.