Skip to content

APM logs correlation query missing dataSource for external datasources#2625

Merged
ps48 merged 1 commit intoopensearch-project:mainfrom
ps48:query-logs-with-datasourceid
Mar 25, 2026
Merged

APM logs correlation query missing dataSource for external datasources#2625
ps48 merged 1 commit intoopensearch-project:mainfrom
ps48:query-logs-with-datasourceid

Conversation

@ps48
Copy link
Copy Markdown
Member

@ps48 ps48 commented Mar 25, 2026

Description

  • Fixed logs correlation query in the Service Correlations Flyout not including the dataSource field in the dataset config, causing 503 "No Living connections" errors when using external datasources
  • The spans query correctly passed dataSource.id but the logs query omitted it, even though dataSourceId was already available from the useCorrelatedLogs hook
  • Added unit tests verifying dataSource propagation for both spans and logs queries

Root Cause

In service_correlations_flyout.tsx, the logs dataset config only copied id and title from the correlated log dataset, while the spans dataset config (line 278) correctly included dataSource: { id: datasourceId }. Without dataSource, the PPL query was routed to the local cluster instead of the external datasource.

Issues Resolved

#2545

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ps48 ps48 added the bug Something isn't working label Mar 25, 2026
@ps48 ps48 merged commit d7f40b1 into opensearch-project:main Mar 25, 2026
13 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants