Skip to content

[AUTO] Increment version to 3.2.0-SNAPSHOT#1178

Merged
dbwiddis merged 2 commits intomainfrom
create-pull-request/3.2.0-SNAPSHOT
Jul 23, 2025
Merged

[AUTO] Increment version to 3.2.0-SNAPSHOT#1178
dbwiddis merged 2 commits intomainfrom
create-pull-request/3.2.0-SNAPSHOT

Conversation

@opensearch-trigger-bot
Copy link
Contributor

  • Incremented version to 3.2.0-SNAPSHOT.

@opensearch-trigger-bot opensearch-trigger-bot bot force-pushed the create-pull-request/3.2.0-SNAPSHOT branch 2 times, most recently from 75ff1b7 to b97b8dd Compare July 8, 2025 00:10
@opensearch-trigger-bot opensearch-trigger-bot bot force-pushed the create-pull-request/3.2.0-SNAPSHOT branch from b97b8dd to 9108b70 Compare July 9, 2025 00:11
@opensearch-trigger-bot opensearch-trigger-bot bot force-pushed the create-pull-request/3.2.0-SNAPSHOT branch from 9108b70 to 77b790a Compare July 16, 2025 00:11
@dbwiddis
Copy link
Member

Failing due to:

java.lang.ClassNotFoundException: org.apache.commons.text.StringSubstitutor

This is another issue with ML Commons including a dependency that we need (MLCreateConnectorInput invokes it) but has a different classpath due to being in a different plugin. Seems opensearch-project/ml-commons#3579 introduced this.

See also opensearch-project/ml-commons#3860 for related issue.

@codecov
Copy link

codecov bot commented Jul 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.66%. Comparing base (4794ac2) to head (3762e3a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1178   +/-   ##
=========================================
  Coverage     77.66%   77.66%           
  Complexity     1192     1192           
=========================================
  Files           102      102           
  Lines          5641     5641           
  Branches        574      574           
=========================================
  Hits           4381     4381           
  Misses          986      986           
  Partials        274      274           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@joshpalis joshpalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Holding off on merging until #1195 is merged

Signed-off-by: opensearch-ci-bot <opensearch-infra@amazon.com>
@dbwiddis dbwiddis force-pushed the create-pull-request/3.2.0-SNAPSHOT branch from bb97fb0 to cc13274 Compare July 23, 2025 23:03
@dbwiddis
Copy link
Member

dbwiddis commented Jul 23, 2025

New error.

/home/runner/work/flow-framework/flow-framework/src/main/java/org/opensearch/flowframework/workflow/AbstractRegisterLocalModelStep.java:31: error: import requires canonical name for FrameworkType
import org.opensearch.ml.common.model.TextEmbeddingModelConfig.FrameworkType;

This is a public enum in a public class. Or was last time I downloaded the class.

Looks like in the latest version the enum has moved to the superclass org.opensearch.ml.common.model.BaseModelConfig so is accessible from the subclass but not from imports from dependencies.

https://docs.oracle.com/javase/specs/jls/se8/html/jls-7.html#jls-7.5.1

Gotta love breaking changes in minor version bumps! :)

Change introduced in opensearch-project/ml-commons#3994 (CC: @nathaliellenaa @b4sjoo @Zhangxunmt please confirm my fix is the correct one)

Signed-off-by: Daniel Widdis <widdis@gmail.com>
@nathaliellenaa
Copy link

New error.

/home/runner/work/flow-framework/flow-framework/src/main/java/org/opensearch/flowframework/workflow/AbstractRegisterLocalModelStep.java:31: error: import requires canonical name for FrameworkType
import org.opensearch.ml.common.model.TextEmbeddingModelConfig.FrameworkType;

This is a public enum in a public class. Or was last time I downloaded the class.

Looks like in the latest version the enum has moved to the superclass org.opensearch.ml.common.model.BaseModelConfig so is accessible from the subclass but not from imports from dependencies.

https://docs.oracle.com/javase/specs/jls/se8/html/jls-7.html#jls-7.5.1

Gotta love breaking changes in minor version bumps! :)

Change introduced in opensearch-project/ml-commons#3994 (CC: @nathaliellenaa @b4sjoo @Zhangxunmt)

@dbwiddis Yep, it should be changed to import org.opensearch.ml.common.model.BaseModelConfig.FrameworkType;. Your changes here looks correct!

@dbwiddis dbwiddis merged commit 8f4931b into main Jul 23, 2025
25 checks passed
@dbwiddis dbwiddis deleted the create-pull-request/3.2.0-SNAPSHOT branch July 23, 2025 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants