[BugFix] Allow specifying ServiceAccountName without creating one#719
Open
walkersilas wants to merge 3 commits intoopensearch-project:mainfrom
Open
[BugFix] Allow specifying ServiceAccountName without creating one#719walkersilas wants to merge 3 commits intoopensearch-project:mainfrom
walkersilas wants to merge 3 commits intoopensearch-project:mainfrom
Conversation
Currently, the ServiceAccountName on the StatefulSet can only be set, when the "create" flag is true. This is a contradiction to the documentation which states that "external service accounts" can be used as well. Signed-off-by: Silas Walker <61501113+walkersilas@users.noreply.github.com>
walkersilas
requested review from
DandyDeveloper,
TheAlgo,
gaiksaya,
peterzhuamazon and
prudhvigodithi
as code owners
Signed-off-by: Silas Walker <61501113+walkersilas@users.noreply.github.com>
Signed-off-by: Silas Walker <61501113+walkersilas@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, the ServiceAccountName on the StatefulSet can only be set, when the "create" flag is true. This is a contradiction to the documentation which states that "external service accounts" can be used as well.
Issues Resolved
No issue exists for this Bug. I just detected it while working with the Helm Chart.
Check List
For any changes to files within Helm chart directories:
CHANGELOG.mdupdated to reflect changeBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.