add support for service annotations in data-prepper chart#723
Open
badal773 wants to merge 2 commits intoopensearch-project:mainfrom
Open
add support for service annotations in data-prepper chart#723badal773 wants to merge 2 commits intoopensearch-project:mainfrom
badal773 wants to merge 2 commits intoopensearch-project:mainfrom
Conversation
badal773
requested review from
DandyDeveloper,
TheAlgo,
gaiksaya,
peterzhuamazon and
prudhvigodithi
as code owners
Signed-off-by: badal773 <badal2002prusty@gmail.com>
Signed-off-by: badal773 <badal2002prusty@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds support for specifying custom annotations on the Kubernetes Service resource in the
data-prepperHelm chart. This allows users to set service annotations (such as for cloud provider integrations) via the chart's values. The chart version is also bumped to reflect this new feature.Service annotation support:
service.annotationsfield tovalues.yamlto allow users to specify custom annotations for the Service resource.data-prepper.annotationsin_helpers.tplto render service annotations.service.yamltemplate to apply the user-provided annotations to the Service metadata.Documentation and versioning:
CHANGELOG.mdto document the new service annotation feature and incremented the chart version to0.3.2.Issues Resolved
#567
Check List
For any changes to files within Helm chart directories:
CHANGELOG.mdupdated to reflect change