fix: prevent NPE and status inconsistency in index insight #4313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuangli-z
requested review from
HenryL27,
Zhangxunmt,
austintlee,
b4sjoo,
dhrubo-os,
jngz-es,
mingshl,
model-collapse,
pyek-bot,
rbhavna,
sam-herman,
xinyual,
ylwu-amzn and
zane-neo
as code owners
shuangli-z
had a problem deploying
to
ml-commons-cicd-env-require-approval
GitHub Actions
Failure
shuangli-z
had a problem deploying
to
ml-commons-cicd-env-require-approval
GitHub Actions
Error
shuangli-z
had a problem deploying
to
ml-commons-cicd-env-require-approval
GitHub Actions
Failure
shuangli-z
had a problem deploying
to
ml-commons-cicd-env-require-approval
GitHub Actions
Error
shuangli-z
requested a deployment
to
ml-commons-cicd-env-require-approval
GitHub Actions
Waiting
shuangli-z
requested a deployment
to
ml-commons-cicd-env-require-approval
GitHub Actions
Waiting
shuangli-z
requested a deployment
to
ml-commons-cicd-env-require-approval
GitHub Actions
Waiting
shuangli-z
requested a deployment
to
ml-commons-cicd-env-require-approval
GitHub Actions
Waiting
shuangli-z
changed the title
shuangli-z
requested a deployment
to
ml-commons-cicd-env-require-approval
GitHub Actions
Waiting
shuangli-z
requested a deployment
to
ml-commons-cicd-env-require-approval
GitHub Actions
Waiting
shuangli-z
requested a deployment
to
ml-commons-cicd-env-require-approval
GitHub Actions
Waiting
shuangli-z
requested a deployment
to
ml-commons-cicd-env-require-approval
GitHub Actions
Waiting
xinyual
reviewed
Oct 20, 2025
| writeIndexInsight( | ||
| indexInsight, | ||
| tenantId, | ||
| ActionListener.wrap(r -> { runWithPrerequisites(tenantId, listener); }, listener::onFailure) |
There was a problem hiding this comment.
Why in here we don't save the failure status?
There was a problem hiding this comment.
Because if writing the initial GENERATING status fails, the insight will not be stored, so there is no need to update to FAILED status. Also, attempting to save a FAILED status would likely fail for the same reason.
Signed-off-by: shuangli-z <[email protected]>
Signed-off-by: shuangli-z <[email protected]>
… is written Signed-off-by: shuangli-z <[email protected]>
Signed-off-by: shuangli-z <[email protected]>
ylwu-amzn
force-pushed
the
fixIndexInsightBug
branch
from
2011b47 to
04c76bd
Compare
ylwu-amzn
requested a deployment
to
ml-commons-cicd-env-require-approval
GitHub Actions
Waiting
ylwu-amzn
requested a deployment
to
ml-commons-cicd-env-require-approval
GitHub Actions
Waiting
ylwu-amzn
requested a deployment
to
ml-commons-cicd-env-require-approval
GitHub Actions
Waiting
ylwu-amzn
requested a deployment
to
ml-commons-cicd-env-require-approval
GitHub Actions
Waiting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Minor fixes for index insight feature:
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.