Fixing regex bypass issue #4336
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zane-neo
requested review from
HenryL27,
Zhangxunmt,
austintlee,
b4sjoo,
dhrubo-os,
jngz-es,
mingshl,
model-collapse,
pyek-bot,
rbhavna,
sam-herman,
xinyual and
ylwu-amzn
as code owners
Signed-off-by: zane-neo <[email protected]>
zane-neo
force-pushed
the
fix-regex-bypass
branch
from
263357d to
922075c
Compare
zane-neo
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
zane-neo
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
zane-neo
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
zane-neo
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
Signed-off-by: zane-neo <[email protected]>
zane-neo
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
zane-neo
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
zane-neo
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
zane-neo
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
zane-neo
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
zane-neo
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #4336 +/- ##
============================================
- Coverage 80.14% 80.12% -0.03%
- Complexity 10172 10174 +2
============================================
Files 854 855 +1
Lines 44219 44239 +20
Branches 5113 5113
============================================
+ Hits 35440 35447 +7
- Misses 6630 6641 +11
- Partials 2149 2151 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zane-neo
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
zane-neo
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
Hailong-am
reviewed
Oct 22, 2025
| Duration connectionTimeout, | ||
| Duration readTimeout, | ||
| int maxConnections, | ||
| AtomicBoolean connectorPrivateIpEnabled |
There was a problem hiding this comment.
can we use bool here? what's the reason to use atomicBoolean
There was a problem hiding this comment.
Agree that boolean is better, I tried to change all the occurrence of this connectorPrivateIpEnabled to boolean all the way back to where it's defined, but there's more UTs need to be changed. But changing to boolean is correct direction, let me try again this change.
65 tasks
ylwu-amzn
reviewed
Oct 22, 2025
| import software.amazon.awssdk.http.async.SdkAsyncHttpClient; | ||
|
|
||
| @Log4j2 | ||
| public class ValidatingHttpClient implements SdkAsyncHttpClient { |
There was a problem hiding this comment.
Suggest use a better class name.
rithin-pullela-aws
approved these changes
Oct 22, 2025
|
let's backport to 3.3 |
65 tasks
Signed-off-by: zane-neo <[email protected]>
zane-neo
force-pushed
the
fix-regex-bypass
branch
from
285123f to
cff9dd5
Compare
zane-neo
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
zane-neo
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
zane-neo
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
zane-neo
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
zane-neo
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
zane-neo
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
zane-neo
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
zane-neo
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
zane-neo
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
zane-neo
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
zane-neo
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
zane-neo
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
Signed-off-by: zane-neo <[email protected]>
zane-neo
force-pushed
the
fix-regex-bypass
branch
from
7e45e1a to
56fe122
Compare
zane-neo
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
zane-neo
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
zane-neo
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
xinyual
reviewed
Oct 23, 2025
common/src/main/java/org/opensearch/ml/common/httpclient/MLValidatableAsyncHttpClient.java
Show resolved
Hide resolved
xinyual
approved these changes
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix connector regex bypass issue
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.