-
Notifications
You must be signed in to change notification settings - Fork 184
Fix agent type update #4341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix agent type update #4341
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Can you rebase your main with current main? Looks like around 27 commits are pushed
Signed-off-by: Owais Kazi <[email protected]>
7101c48 to
f208b34
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rest LGTM, thanks for this!
common/src/main/java/org/opensearch/ml/common/transport/agent/MLAgentUpdateInput.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Owais Kazi <[email protected]>
|
Netty errors. Dependent on #4339 |
@owaiskazi19 you need #4338 the one i linked is for 2.19 |
Description
Fix agent update
{ "error": { "root_cause": [ { "type": "illegal_argument_exception", "reason": "Agent type cannot be updated" } ], "type": "illegal_argument_exception", "reason": "Agent type cannot be updated" }, "status": 400 }Related Issues
Resolves #4340
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.