Skip to content

Fix agent type update #4341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix agent type update #4341

wants to merge 2 commits into from
+57 −0

Conversation

@owaiskazi19
Copy link
Member

Description

Fix agent update

{
"error": {
  "root_cause": [
  {
  "type": "illegal_argument_exception",
  "reason": "Agent type cannot be updated"
  }
  ],
  "type": "illegal_argument_exception",
  "reason": "Agent type cannot be updated"
  },
  "status": 400
}

Related Issues

Resolves #4340

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@owaiskazi19 owaiskazi19 requested a deployment to ml-commons-cicd-env-require-approval October 23, 2025 00:33 — with GitHub Actions Waiting
@owaiskazi19 owaiskazi19 requested a deployment to ml-commons-cicd-env-require-approval October 23, 2025 00:33 — with GitHub Actions Waiting
@owaiskazi19 owaiskazi19 requested a deployment to ml-commons-cicd-env-require-approval October 23, 2025 00:33 — with GitHub Actions Waiting
@owaiskazi19 owaiskazi19 requested a deployment to ml-commons-cicd-env-require-approval October 23, 2025 00:33 — with GitHub Actions Waiting
rithin-pullela-aws
rithin-pullela-aws approved these changes Oct 23, 2025
View reviewed changes
Copy link
Contributor

@rithin-pullela-aws rithin-pullela-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Can you rebase your main with current main? Looks like around 27 commits are pushed

@owaiskazi19 owaiskazi19 had a problem deploying to ml-commons-cicd-env-require-approval October 23, 2025 01:50 — with GitHub Actions Failure
@owaiskazi19 owaiskazi19 had a problem deploying to ml-commons-cicd-env-require-approval October 23, 2025 01:50 — with GitHub Actions Error
@owaiskazi19 owaiskazi19 had a problem deploying to ml-commons-cicd-env-require-approval October 23, 2025 01:50 — with GitHub Actions Error
@owaiskazi19 owaiskazi19 had a problem deploying to ml-commons-cicd-env-require-approval October 23, 2025 01:50 — with GitHub Actions Failure
pyek-bot
pyek-bot reviewed Oct 23, 2025
View reviewed changes
Copy link
Collaborator

@pyek-bot pyek-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM, thanks for this!

@owaiskazi19 owaiskazi19 requested a review from pyek-bot October 23, 2025 17:28
@owaiskazi19 owaiskazi19 had a problem deploying to ml-commons-cicd-env-require-approval October 23, 2025 17:29 — with GitHub Actions Failure
@owaiskazi19 owaiskazi19 had a problem deploying to ml-commons-cicd-env-require-approval October 23, 2025 17:29 — with GitHub Actions Error
@owaiskazi19 owaiskazi19 had a problem deploying to ml-commons-cicd-env-require-approval October 23, 2025 17:29 — with GitHub Actions Failure
@owaiskazi19 owaiskazi19 had a problem deploying to ml-commons-cicd-env-require-approval October 23, 2025 17:29 — with GitHub Actions Error
@owaiskazi19
Copy link
Member Author

Netty errors. Dependent on #4339

 * What went wrong:
Could not determine the dependencies of task ':opensearch-ml-plugin:dependencyLicenses'.
> Failed to query the value of task ':opensearch-ml-plugin:dependencyLicenses' property 'dependencies'.
   > Could not resolve all dependencies for configuration ':opensearch-ml-plugin:runtimeClasspath'.
      > Could not resolve io.netty:netty-codec-http:4.1.125.Final.
        Required by:
            project :opensearch-ml-plugin > project :opensearch-ml-algorithms > org.opensearch:opensearch-remote-metadata-sdk-ddb-client:3.4.0.0-SNAPSHOT:20251023.014719-2
            project :opensearch-ml-plugin > project :opensearch-ml-algorithms > org.opensearch:opensearch-remote-metadata-sdk-ddb-client:3.4.0.0-SNAPSHOT:20251023.014719-2 > io.netty:netty-codec-http2:4.1.125.Final
         > Conflict found for module 'io.netty:netty-codec-http': between versions 4.1.125.Final and 4.1.124.Final
      > Could not resolve io.netty:netty-codec-http2:4.1.125.Final.
        Required by:
            project :opensearch-ml-plugin > project :opensearch-ml-algorithms > org.opensearch:opensearch-remote-metadata-sdk-ddb-client:3.4.0.0-SNAPSHOT:20251023.014719-2
         > Conflict found for module 'io.netty:netty-codec-http2': between versions 4.1.125.Final and 4.1.124.Final
      > Could not resolve io.netty:netty-codec:4.1.125.Final

@brianf-aws
Copy link
Contributor

Netty errors. Dependent on #4339

 * What went wrong:
Could not determine the dependencies of task ':opensearch-ml-plugin:dependencyLicenses'.
> Failed to query the value of task ':opensearch-ml-plugin:dependencyLicenses' property 'dependencies'.
   > Could not resolve all dependencies for configuration ':opensearch-ml-plugin:runtimeClasspath'.
      > Could not resolve io.netty:netty-codec-http:4.1.125.Final.
        Required by:
            project :opensearch-ml-plugin > project :opensearch-ml-algorithms > org.opensearch:opensearch-remote-metadata-sdk-ddb-client:3.4.0.0-SNAPSHOT:20251023.014719-2
            project :opensearch-ml-plugin > project :opensearch-ml-algorithms > org.opensearch:opensearch-remote-metadata-sdk-ddb-client:3.4.0.0-SNAPSHOT:20251023.014719-2 > io.netty:netty-codec-http2:4.1.125.Final
         > Conflict found for module 'io.netty:netty-codec-http': between versions 4.1.125.Final and 4.1.124.Final
      > Could not resolve io.netty:netty-codec-http2:4.1.125.Final.
        Required by:
            project :opensearch-ml-plugin > project :opensearch-ml-algorithms > org.opensearch:opensearch-remote-metadata-sdk-ddb-client:3.4.0.0-SNAPSHOT:20251023.014719-2
         > Conflict found for module 'io.netty:netty-codec-http2': between versions 4.1.125.Final and 4.1.124.Final
      > Could not resolve io.netty:netty-codec:4.1.125.Final

@owaiskazi19 you need #4338

the one i linked is for 2.19

@owaiskazi19
Fix agent type update
c991f1e 
Signed-off-by: Owais Kazi <[email protected]>
@owaiskazi19
Added bwc checks
6b2dad5 
Signed-off-by: Owais Kazi <[email protected]>
@owaiskazi19 owaiskazi19 deployed to ml-commons-cicd-env-require-approval October 24, 2025 06:55 — with GitHub Actions Active
@owaiskazi19 owaiskazi19 had a problem deploying to ml-commons-cicd-env-require-approval October 24, 2025 06:55 — with GitHub Actions Failure
@owaiskazi19 owaiskazi19 temporarily deployed to ml-commons-cicd-env-require-approval October 24, 2025 06:55 — with GitHub Actions Inactive
@owaiskazi19 owaiskazi19 temporarily deployed to ml-commons-cicd-env-require-approval October 24, 2025 06:55 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Oct 24, 2025

Codecov Report

❌ Patch coverage is 63.63636% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.12%. Comparing base (eec7179) to head (6b2dad5).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../ml/common/transport/agent/MLAgentUpdateInput.java 63.63% 1 Missing and 3 partials ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #4341      +/-   ##
============================================
- Coverage     80.13%   80.12%   -0.02%     
+ Complexity    10171    10162       -9     
============================================
  Files           854      854              
  Lines         44219    44230      +11     
  Branches       5113     5117       +4     
============================================
+ Hits          35437    35440       +3     
- Misses         6631     6637       +6     
- Partials       2151     2153       +2
Flag Coverage Δ
ml-commons 80.12% <63.63%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@b4sjoo b4sjoo Awaiting requested review from b4sjoo b4sjoo is a code owner

@dhrubo-os dhrubo-os Awaiting requested review from dhrubo-os dhrubo-os is a code owner

@mingshl mingshl Awaiting requested review from mingshl mingshl is a code owner

@jngz-es jngz-es Awaiting requested review from jngz-es jngz-es is a code owner

@model-collapse model-collapse Awaiting requested review from model-collapse model-collapse is a code owner

@rbhavna rbhavna Awaiting requested review from rbhavna rbhavna is a code owner

@ylwu-amzn ylwu-amzn Awaiting requested review from ylwu-amzn ylwu-amzn is a code owner

@zane-neo zane-neo Awaiting requested review from zane-neo zane-neo is a code owner

@Zhangxunmt Zhangxunmt Awaiting requested review from Zhangxunmt Zhangxunmt is a code owner

@austintlee austintlee Awaiting requested review from austintlee austintlee is a code owner

@HenryL27 HenryL27 Awaiting requested review from HenryL27 HenryL27 is a code owner

@sam-herman sam-herman Awaiting requested review from sam-herman sam-herman is a code owner

@xinyual xinyual Awaiting requested review from xinyual xinyual is a code owner

@pyek-bot pyek-bot Awaiting requested review from pyek-bot pyek-bot is a code owner

1 more reviewer

@rithin-pullela-aws rithin-pullela-aws rithin-pullela-aws approved these changes

Reviewers whose approvals may not affect merge requirements

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] Update agent API silently fails when changing agent type

4 participants

@owaiskazi19 @brianf-aws @pyek-bot @rithin-pullela-aws