Skip to content

Services map support for traces and fields mapping sample#1475

Closed
YANG-DB wants to merge 7 commits intoopensearch-project:2.xfrom
YANG-DB:repository_setup
Closed

Services map support for traces and fields mapping sample#1475
YANG-DB wants to merge 7 commits intoopensearch-project:2.xfrom
YANG-DB:repository_setup

Conversation

@YANG-DB
Copy link
Copy Markdown
Member

@YANG-DB YANG-DB commented Mar 20, 2023

Description

added a service mapping support for both the traces correlation between

  • Metrics.serviceName <-> services.name
  • Traces.serviceName <-> services.name

This will allow for simple and common integrations of data-prepper proprietary schemas

This PR is also addressing the fields mapping aliasing for similar semantic meaning fields that have different names -

Issues Resolved

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@YANG-DB YANG-DB requested a review from a team as a code owner March 20, 2023 22:03
@YANG-DB YANG-DB added enhancement New feature or request v2.7.0 integration Integration project labels Mar 20, 2023
@YANG-DB YANG-DB self-assigned this Mar 20, 2023
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will cause a merge conflict with the directory typo fix in #1470 (commit e547dd9d) can we preemptively apply the change here?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

@derek-ho
Copy link
Copy Markdown
Collaborator

How did you test this/what is this concrete deliverable this PR is doing? I couldn't really comprehend on first pass. Also can you make sure all of the PRs you are doing are aimed at Main branch? Or at least back ported in a timely fashion? If they are not it will create a big headache with conflicts later on when other changes are needed

@YANG-DB
Copy link
Copy Markdown
Member Author

YANG-DB commented Mar 21, 2023

the PR is aiming for adding documentation and description sample of the services concept support for the Integration schema
In addition

  • adding fields mapping support sample (using data-prepper)
  • adding Observability Correlation using serviceName
  • sample of data-prepper dashboard for serviceMap integration

YANG-DB added 2 commits March 21, 2023 13:03
add rest endpoint documentation for integration-fields

Signed-off-by: YANGDB <yang.db.dev@gmail.com>
@YANG-DB YANG-DB removed the v2.7.0 label Apr 3, 2023
@YANG-DB YANG-DB added this to the 2.8 milestone Apr 3, 2023
@YANG-DB YANG-DB changed the base branch from 2.x to main April 4, 2023 23:52
@YANG-DB YANG-DB changed the base branch from main to 2.x April 4, 2023 23:52
@YANG-DB
Copy link
Copy Markdown
Member Author

YANG-DB commented Apr 5, 2023

concluded with - #1494
removing ..

@YANG-DB YANG-DB closed this Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport main enhancement New feature or request integration Integration project

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants