Add TimeSeries Support to SDG #962
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Pydantic Model for TimeSeries settings, update TimeSeries Partitioner, update Mapping SDG to use timeseries data, and add params to basic generators in Mapping SDG Pylint fixes Signed-off-by: Ian Hoang <[email protected]>
IanHoang
requested review from
OVI3D0,
VijayanB,
beaioun,
gkamat and
rishabh6788
as code owners
Signed-off-by: Ian Hoang <[email protected]>
Signed-off-by: Ian Hoang <[email protected]>
OVI3D0
reviewed
Oct 30, 2025
osbenchmark/synthetic_data_generator/strategies/custom_module_strategy.py
Outdated
Show resolved
Hide resolved
OVI3D0
reviewed
Oct 30, 2025
osbenchmark/synthetic_data_generator/strategies/mapping_strategy.py
Outdated
Show resolved
Hide resolved
OVI3D0
reviewed
Oct 30, 2025
gkamat
requested changes
Oct 31, 2025
osbenchmark/synthetic_data_generator/strategies/custom_module_strategy.py
Outdated
Show resolved
Hide resolved
osbenchmark/synthetic_data_generator/strategies/custom_module_strategy.py
Show resolved
Hide resolved
Signed-off-by: Ian Hoang <[email protected]>
Signed-off-by: Ian Hoang <[email protected]>
Collaborator
Author
|
@gkamat Ready for another review |
gkamat
approved these changes
Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for TimeSeries settings. Users can now add the following config to the SDG configs and specify a timestamp field as well as the frequency of the timestamp. Data outputted is written in order. The PR also adds the option to start writing data with at a specific suffix.
The example above instructs SDG to start generating files with file paritions starting at suffix 0, and for SDG to generate timestamps in epoch format, each entry should be a ms apart, timestamp generated should be between 1/1/2024-1/31/2024, and should be written in @timestamp field.
This was demo'd at OpenSearchCon NA.
Issues Resolved
#862
Testing
New functionality includes testing
Tested with custom logic
Tested with index mapping
Tested E2E with
--test-documentflag for both approachesConfirmed that the output was as intended
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.