-
Notifications
You must be signed in to change notification settings - Fork 115
Add looped mode support for bulk ingestion operation. #968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Rishabh Singh <[email protected]>
Signed-off-by: Rishabh Singh <[email protected]>
gkamat
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be useful for "looped" to be an integer instead, which would indicate the number of iterations to loop. That would operate as in iteration-based mode and the user could specify "1000" for a thousand iterations, and "0" for infinite -- the current behaviour.
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-1.16 1.16
# Navigate to the new working tree
pushd ../.worktrees/backport-1.16
# Create a new branch
git switch --create backport/backport-968-to-1.16
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 0522e68f577d2e99de76a516321932eef53313e5
# Push it to GitHub
git push --set-upstream origin backport/backport-968-to-1.16
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-1.16Then, create a pull request where the |
Signed-off-by: Rishabh Singh <[email protected]> (cherry picked from commit 0522e68)
Signed-off-by: Rishabh Singh <[email protected]> (cherry picked from commit 0522e68)
Signed-off-by: Rishabh Singh <[email protected]> (cherry picked from commit 0522e68)
Signed-off-by: Rishabh Singh <[email protected]> (cherry picked from commit 0522e68)
Signed-off-by: Rishabh Singh <[email protected]> (cherry picked from commit 0522e68)
Signed-off-by: Rishabh Singh <[email protected]> (cherry picked from commit 0522e68)
Description
This PR added
loopedmode parameter for bulk operations. Using this users will be able run ingestion even when the corpus is not big enough to sustain long term indexing at any specified rate.If not
time-periodis defined and looped mode is set to true then ingestion would run indefinitely.Example:
Issues Resolved
[List any issues this PR will resolve]
Testing
[Describe how this change was tested]
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.