Changes to aid integration between SDG and Streaming ingestion #978
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
some fixes. Signed-off-by: Govind Kamat <[email protected]>
gkamat
requested review from
IanHoang,
OVI3D0,
VijayanB,
beaioun and
rishabh6788
as code owners
IanHoang
reviewed
Nov 4, 2025
Comment on lines
+58
to
+60
| if size == 0: | ||
| return | ||
| yield key |
Collaborator
There was a problem hiding this comment.
should we add a comment here that the streaming terminates here when empty file is encountered?
Collaborator
Author
There was a problem hiding this comment.
Yes, that would be appropriate. Right now, the user model might change based on feedback, but once confirmed, this will be refactored.
IanHoang
reviewed
Nov 4, 2025
| for key in keys['Contents']: | ||
| rsl.append(key['Key']) | ||
| def _get_next_key(self): | ||
| if len(self.keys) > 2 and self.keys.endswith('**'): |
Collaborator
There was a problem hiding this comment.
Why does length of self.keys need to be at least 2?
len(self.keys) > 2
Collaborator
There was a problem hiding this comment.
So that readers can better understand what's happening, we can abstract these clauses into methods that explain the action and return booleans
len(self.keys) > 2 and self.keys.endswith('**')
and
len(self.keys) > 1 and self.keys[-1] == '*':
Collaborator
Author
There was a problem hiding this comment.
Will add this in the next update.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes to aid integration between SDG and Streaming ingestion and some fixes.
Testing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.