Skip to content

Add tooling_skip field option to preserve manually-maintained protobuf fields #378

Merged
lucy66hw merged 3 commits intoopensearch-project:mainfrom
lucy66hw:skip_deprecation
Jan 29, 2026
Merged

Add tooling_skip field option to preserve manually-maintained protobuf fields #378
lucy66hw merged 3 commits intoopensearch-project:mainfrom
lucy66hw:skip_deprecation

Conversation

@lucy66hw
Copy link
Collaborator

@lucy66hw lucy66hw commented Jan 29, 2026

Description

Adds support for the [(tooling_skip) = true] option in protobuf files to mark fields that are manually maintained for gRPC and should not be marked as deprecated after postprocessing.

Test Plan

1, unit test.
2, Local test :
a) Add a [(tooling_skip) = true] option to protos/schemas/common.proto:
Map of fully-qualified field path -> typed value.
map<string, BinaryFieldValue> field_values = 4 [(tooling_skip) = true];
b) Run postprocessing processing:
c) Verified field_values remains in the output without [deprecated = true]

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…elds

Signed-off-by: xil <fridalu66@gmail.com>
@lucy66hw lucy66hw marked this pull request as ready for review January 29, 2026 00:13
@codecov
Copy link

codecov bot commented Jan 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.41%. Comparing base (d74c385) to head (9e84400).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #378      +/-   ##
==========================================
+ Coverage   56.19%   56.41%   +0.21%     
==========================================
  Files          17       17              
  Lines        1397     1404       +7     
  Branches      375      382       +7     
==========================================
+ Hits          785      792       +7     
- Misses        528      611      +83     
+ Partials       84        1      -83     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: xil <fridalu66@gmail.com>
@lucy66hw lucy66hw changed the title Add @grpc_only annotation to preserve manually-maintained protobuf fields Add tooling_skip field option to preserve manually-maintained protobuf fields Jan 29, 2026
Signed-off-by: xil <fridalu66@gmail.com>
@lucy66hw lucy66hw merged commit 52c929c into opensearch-project:main Jan 29, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants