Add support of BinaryFieldValues for non _source primitive array indexing#387
Add support of BinaryFieldValues for non _source primitive array indexing#387laminelam wants to merge 1 commit intoopensearch-project:mainfrom
Conversation
…xing Signed-off-by: Lamine Idjeraoui <lidjeraoui@apple.com>
laminelam
requested review from
amberzsy,
karenyrx,
lucy66hw and
philiplhchan
as code owners
karenyrx
left a comment
karenyrx
left a comment
There was a problem hiding this comment.
Thanks @laminelam this PR generally looks good, we are waiting on the feature to add back tooling_skip support before merging your PR (as it was recently reverted in https://github.com/opensearch-project/opensearch-protobufs/pull/387/changes)
| // Map of fully-qualified field path -> typed value. | ||
| map<string, BinaryFieldValue> field_values = 4 [(tooling_skip) = true]; |
There was a problem hiding this comment.
| // Map of fully-qualified field path -> typed value. | |
| map<string, BinaryFieldValue> field_values = 4 [(tooling_skip) = true]; | |
| // EXPERIMENTAL field - may have breaking changes | |
| // [optional] Map of fully-qualified field path -> typed value. | |
| map<string, BinaryFieldValue> field_values = 4 [(tooling_skip) = true]; |
There was a problem hiding this comment.
Just to give us an escape hatch in case this needs any tuning :)
There was a problem hiding this comment.
Additionally can you document with which operation this should be used for? (create/update/index/delete) and which fields this is not compatible with? e.g. can both object and field_values provided?
|
|
||
| message BinaryFieldValue { | ||
| oneof binary_field_value { | ||
| BytesValue bytes_value = 1; |
There was a problem hiding this comment.
Could you add some comments above all the newly added fields to clarify their usage, along with the [optional] / [required] keyword to adhere to the current style in the repo?
2 participants
This is part of a broader contribution to add support of non _source primitive array indexing
For now, only float arrays are supported, as well as BytesValue.
Two options are offered:
Issues Resolved
opensearch-project/opensearch-api-specification#1035
opensearch-project/OpenSearch#19638
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.