Skip to content

Revert 52c929c#388

Merged
lucy66hw merged 2 commits intoopensearch-project:mainfrom
karenyrx:rev
Feb 16, 2026
Merged

Revert 52c929c#388
lucy66hw merged 2 commits intoopensearch-project:mainfrom
karenyrx:rev

Conversation

@karenyrx
Copy link
Collaborator

@karenyrx karenyrx commented Feb 16, 2026

Description

  1. This commit 52c929c causes an error in protobuf autogeneration:

> opensearch_api_tools@1.0.0 backward-compat
> ts-node tools/proto-convert/src/postprocessing/BackwardCompatibleWriter.ts --dry-run

/home/runner/work/opensearch-api-specification/opensearch-api-specification/node_modules/protobufjs/src/parse.js:96
        return Error("illegal " + (name || "token") + " '" + token + "' (" + (filename ? filename + ", " : "") + "line " + tn.line + ")");

So temporarily reverting for now as the fix is being worked on.

  1. As additional followup, modifying GHA to trigger the protobuf autogeneration workflow whenever protobuf tooling-related files ( in the tools/proto-convert folder) have changed to ensure workflow still works with the PR changes.

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Karen X <karenxyr@gmail.com>
@codecov
Copy link

codecov bot commented Feb 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.86%. Comparing base (eb0da83) to head (2fc274c).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #388      +/-   ##
==========================================
- Coverage   91.90%   91.86%   -0.05%     
==========================================
  Files          15       15              
  Lines        1371     1364       -7     
  Branches      372      374       +2     
==========================================
- Hits         1260     1253       -7     
+ Misses        110      105       -5     
- Partials        1        6       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Karen X <karenxyr@gmail.com>
@lucy66hw lucy66hw marked this pull request as ready for review February 16, 2026 23:00
@lucy66hw lucy66hw merged commit 9fd701d into opensearch-project:main Feb 16, 2026
16 checks passed
@karenyrx karenyrx changed the title Revert 3317a9a Revert 52c929c Feb 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants