Add protobuf definitions for TermsAggregation, MinAggregation and MaxAggregation#391
Open
yiyuabc wants to merge 1 commit intoopensearch-project:mainfrom
Open
Add protobuf definitions for TermsAggregation, MinAggregation and MaxAggregation#391yiyuabc wants to merge 1 commit intoopensearch-project:mainfrom
yiyuabc wants to merge 1 commit intoopensearch-project:mainfrom
Conversation
5ac6cef to
0fc04eb
Compare
Collaborator
|
@yiyuabc The common.proto can be generated automatically. Could you remove the changes from common.proto. once the change land, we can manually run proto convert wf. |
0fc04eb to
d787b69
Compare
lucy66hw
reviewed
Feb 25, 2026
CHANGELOG.md
Outdated
| - Add BoostingQuery and SimpleQueryString protos ([#376](https://github.com/opensearch-project/opensearch-protobufs/pull/376)) | ||
| - Add protobuf generation documentation and remove unused BUILD dependency ([#379](https://github.com/opensearch-project/opensearch-protobufs/pull/379)) | ||
| - Test Coverage Improvements ([#380](https://github.com/opensearch-project/opensearch-protobufs/pull/380)) | ||
| - Add TermsAggregation, MinAggregation, MaxAggregation and FilterAggregation support in AggregationContainer and add TermsAggregate, MinAggregate, and MaxAggregate variants (DoubleTermsAggregate, LongTermsAggregate, StringTermsAggregate, UnmappedTermsAggregate) in Aggregate |
Collaborator
There was a problem hiding this comment.
could you add PR number at the end?
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #391 +/- ##
=======================================
Coverage 95.10% 95.10%
=======================================
Files 15 15
Lines 1389 1389
Branches 377 385 +8
=======================================
Hits 1321 1321
+ Misses 67 62 -5
- Partials 1 6 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
85abd26 to
3524eb0
Compare
d6f3122 to
17070eb
Compare
Signed-off-by: Yiyu Pan <yypan14@gmail.com>
17070eb to
8061a1c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for TermsAggregation, MinAggregation and MaxAggregation in the OpenSearch protobuf definitions while filtering out unsupported aggregation types to reduce complexity and maintain a focused protobuf schema.
Changes
Updated configuration
tools/proto-convert/src/config/spec-filter.yaml(+128 lines)Modified
common.protoUpdated documentation
CHANGELOG.mdReasoning
Regeneration process
Following the Protobuf Local Convert Guide:
spec-filter.yamlwith exclusion listnpm run preprocessingnpx @openapitools/openapi-generator-cli generatenpm run postprocessingLink to OpenSearch PR: Add Terms/Min/Max aggregation support for gRPC transport (request and response) OpenSearch#20676
Issues Resolved
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.